Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Please specify the admin custom URL" error on app:config:import CLI command #22281

Merged
merged 2 commits into from
Apr 20, 2019

Conversation

davidalger
Copy link
Member

Description (*)

Running bin/magento app:config:import results in following error message when admin/url/use_custom is present and set 1 regardless of whether or not there is also a value specified for admin/url/custom:

davidalger:03:36 PM:/sites/github-15090.mage (github-15090) $ bin/magento app:config:import
Processing configurations data from configuration file...
Import failed: Please specify the admin custom URL.

Fixed Issues (if relevant)

  1. app:config:import fails with "Please specify the admin custom URL." #15090

Manual testing scenarios (*)

  1. Install Magento locally
  2. Add following to env.php
    'system' => [
        'default' => [
            'web' => [
                'unsecure' => [
                    'base_url' => 'https://github-15090.mage.test/',
                    'base_link_url' => 'https://github-15090.mage.test/'
                ],
                'secure' => [
                    'base_url' => 'https://github-15090.mage.test/',
                    'base_link_url' => 'https://github-15090.mage.test/'
                ]
            ],
            'admin' => [
                'url' => [
                    'custom' => 'https://github-15090-admin.mage.test/',
                    'use_custom' => 1
                ]
            ],
        ],
        'websites' => [
            'admin' => [
                'web' => [
                    'unsecure' => [
                        'base_url' => 'https://github-15090-admin.mage.test/',
                        'base_link_url' => 'https://github-15090-admin.mage.test/'
                    ],
                    'secure' => [
                        'base_url' => 'https://github-15090-admin.mage.test/',
                        'base_link_url' => 'https://github-15090-admin.mage.test/'
                    ]
                ]
            ]
        ]
    ]
  1. Run bin/magento app:config:import

Expected Result

davidalger:03:38 PM:/sites/github-15090.mage (github-15090 *) $ bin/magento app:config:import
Processing configurations data from configuration file...
System config was processed

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2019

Hi @davidalger. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4751 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @davidalger, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@davidalger davidalger deleted the github-15090 branch March 30, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants