Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Please specify the admin custom URL" error on app:config:import CLI command #22281

Merged
merged 2 commits into from
Apr 20, 2019
Merged

Fixed "Please specify the admin custom URL" error on app:config:import CLI command #22281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8434d74
Fixed #15090: Update Magento_Config module to allow admin/url/use_cus…
davidalger Apr 10, 2019
e340978
Fix static test.
nmalevanec Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/code/Magento/Config/Model/Config/Backend/Admin/Usecustom.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
namespace Magento\Config\Model\Config\Backend\Admin;

/**
* Process custom admin url during configuration value save process.
*
* @api
* @since 100.0.2
*/
Expand Down Expand Up @@ -56,8 +58,9 @@ public function beforeSave()
{
$value = $this->getValue();
if ($value == 1) {
$customUrl = $this->getData('groups/url/fields/custom/value');
if (empty($customUrl)) {
$customUrlField = $this->getData('groups/url/fields/custom/value');
$customUrlConfig = $this->_config->getValue('admin/url/custom');
if (empty($customUrlField) && empty($customUrlConfig)) {
throw new \Magento\Framework\Exception\LocalizedException(__('Please specify the admin custom URL.'));
}
}
Expand Down