Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Admin-Order-Create-Set-Save-address-checkbox-true-as-default #22335

Closed
wants to merge 1 commit into from

Conversation

niravkrish
Copy link
Contributor

Original Pull Request

#21932

Description (*)

When admin creates order for customer
Save Address checkbox is not checked by default
it makes accidental problems when you make order and forget to check it - you need to add all customer address data again in new order

I set this checkbox state AS DEFAULT

Fixed Issues (if relevant)

  1. Admin Order Create - Save address as default community-features#106: Admin Order Create - Save address as default

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4759 has been created to process this Pull Request

@AlexWorking AlexWorking self-assigned this Apr 15, 2019
@ghost ghost unassigned AlexWorking Apr 15, 2019
@ghost
Copy link

ghost commented Apr 15, 2019

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@VasylShvorak VasylShvorak self-assigned this Apr 15, 2019
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niravkrish original commit author must be preserved

@orlangur
Copy link
Contributor

@niravkrish commit is still not fixed.

@sidolov
Copy link
Contributor

sidolov commented Apr 29, 2019

@niravkrish , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants