Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin-Order-Create-Set-Save-address-checkbox-true-as-default-#106 #21932

Conversation

krnshah
Copy link
Contributor

@krnshah krnshah commented Mar 26, 2019

Description (*)

When admin creates order for customer
Save Address checkbox is not checked by default
it makes accidental problems when you make order and forget to check it - you need to add all customer address data again in new order

I set this checkbox state AS DEFAULT

Fixed Issues (if relevant)

  1. Admin Order Create - Save address as default community-features#106: Admin Order Create - Save address as default

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @krnshah. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Mar 26, 2019

@krnshah unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@krnshah krnshah requested a review from davidalger March 26, 2019 09:20
@dmytro-ch dmytro-ch self-assigned this Mar 26, 2019
@dmytro-ch dmytro-ch self-requested a review March 26, 2019 11:58
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krnshah,
thank you for your contribution!
Could you please check the CR comment?

@davidalger davidalger removed their request for review March 28, 2019 22:14
@krnshah krnshah requested a review from dmytro-ch April 1, 2019 05:40
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4636 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost ghost added the Progress: accept label Apr 10, 2019
@magento-engcom-team magento-engcom-team merged commit ef181ca into magento:2.3-develop Apr 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @krnshah, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants