joinUrlRewrite. Join on non-existing column #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joinUrlRewrite() tried to join on a non-existing column in `core_url_rewrite`. Before the fix, this join was done with the product entity_id, on the entity_id column of core_url_rewrite. This column does not exists in core_url_rewrite. I've changed to query to join on product_id in core_url_rewrite. It also used a conditional statement where type = 2. But column `type` does not exist in core_url_rewrite. I've removed this conditional statement. Before fix, Magento would throw an exception. After fix, it joins the correct columns
|
Thank you very much for your post. |
magento-team
pushed a commit
that referenced
this pull request
Feb 27, 2015
[Ogre] Sprint 23 Contribution
okorshenko
pushed a commit
that referenced
this pull request
Nov 5, 2015
[Mustangs] Milestone 11 Sprint 5 Changes
ghost
mentioned this pull request
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 14, 2018
MAGETWO-91760: Custom address attributes displays with wrong value on…
4 tasks
krnshah
added a commit
to krnshah/magento2
that referenced
this pull request
Mar 26, 2019
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 11, 2019
magento-engcom-team
added a commit
that referenced
this pull request
Apr 11, 2019
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 11, 2019
magento-engcom-team
added a commit
that referenced
this pull request
Apr 11, 2019
Accepted Public Pull Requests: - #22135: Fix broken link in README.md (by @samuel27m) - #21932: Admin-Order-Create-Set-Save-address-checkbox-true-as-default-#106 (by @krnshah) - #22002: Removed unwanted interface implementation (by @vishal-7037) - #21540: Move Magento\Framework\HTTP\ClientInterface preference to app/etc/di.xml (by @kassner) - #21083: Turn on edit mode for product repository when adding children (by @pedrosousa13) Fixed GitHub Issues: - #22001: Magento backend dashboard: Most viewed products tabs gives 404 error in console. (reported by @vishal-7037) has been fixed in #22002 by @vishal-7037 in 2.3-develop branch Related commits: 1. 9e6f56b 2. 8a98f20 - #20366: The parent product doesn't have configurable product options. (reported by @usamahabib786) has been fixed in #21083 by @pedrosousa13 in 2.3-develop branch Related commits: 1. b3b6c90 2. a7f03dd 3. ac98b1f 4. c78535d
amol2jcommerce
pushed a commit
to amol2jcommerce/magento2
that referenced
this pull request
Apr 12, 2019
amol2jcommerce
pushed a commit
to amol2jcommerce/magento2
that referenced
this pull request
Apr 12, 2019
niravkrish
pushed a commit
to niravkrish/magento2
that referenced
this pull request
Apr 15, 2019
niravkrish
pushed a commit
to niravkrish/magento2
that referenced
this pull request
Apr 15, 2019
magento-engcom-team
pushed a commit
to okorshenko/magento2
that referenced
this pull request
May 9, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joinUrlRewrite() tried to join on a non-existing column in
core_url_rewrite.Before the fix, this join was done with the product entity_id, on the entity_id column of core_url_rewrite.
This column does not exists in core_url_rewrite.
I've changed to query to join on product_id in core_url_rewrite.
It also used a conditional statement where type = 2. But column
typedoes not exist in core_url_rewrite. I've removed this conditional statement.Before fix, Magento would throw an exception. After fix, it joins the correct columns