Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Use proper variables for tooltip styles on tablet devices #22367

Conversation

ansari-ziyaurrahman
Copy link
Contributor

Original Pull Request
#22258

Description
There are variables available for tooltip customization. This commit fixes an issue
on tablet devices when trying to use them.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. Open Magento/blank/Magento_Checkout/web/css/source/module/checkout/_tooltip.less file and change the values of the tooltip variables as follows (Usually we do this via theme, but it's for testing purpose only):
    @checkout-tooltip-content__background-color: #fff; @checkout-tooltip-content__border-color: #f2f5f7; @checkout-tooltip-content__active__border-color: @checkout-tooltip-content__border-color;

  2. Navigate to checkout and chec the new styles of field tooltips

  3. Set the width to 768px and check them again:

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @ansari-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansari-krish original commit author must be preserved

@ghost ghost assigned orlangur Apr 16, 2019
@Karlasa Karlasa removed their request for review April 19, 2019 20:18
@orlangur
Copy link
Contributor

@ansari-krish what do you want from me? Problem with commit authorship is still not fixed.

@sidolov
Copy link
Contributor

sidolov commented Apr 30, 2019

@ansari-krish , I am closing this PR now due to inactivity.
Please, preserve the author of original PR and force push the branch if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 30, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2019

Hi @ansari-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants