-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper variables for tooltip styles on tablet devices #22258
Use proper variables for tooltip styles on tablet devices #22258
Conversation
Hi @vovayatsyuk. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you |
Hi @Karlasa, here is your new Magento instance. |
app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_tooltip.less
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi @Karlasa, thank you for the review. |
Hi @vovayatsyuk, thank you for your contribution! |
Description
There are variables available for tooltip customization. This commit fixes an issue
on tablet devices when trying to use them.
Manual testing scenarios
Open
Magento/blank/Magento_Checkout/web/css/source/module/checkout/_tooltip.less
file and change the values of the tooltip variables as follows (Usually we do this via theme, but it's for testing purpose only):Navigate to checkout and chec the new styles of field tooltips
Set the width to
768px
and check them again:Contribution checklist (*)