[Backport] Use proper variables for tooltip styles on tablet devices #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen accessing from the exclude IP list.
…o#20529 - Merge Pull Request magento#20529 from amol2jcommerce/magento2:Fixed-Widget-left-navigation-block-2.2 - Merged commits: 1. 7c4cea2 2. 8a28cca 3. 5af1479
…word forgot password page wrong css used to make it vertially aling middle magento#21162 - Merge Pull Request magento#21162 from mage2pratik/magento2:2.2-develop-PR-port-20914 - Merged commits: 1. 2220707 2. be92e7b 3. bce16b4
…Description are input field in product form while they are defined as textarea magento#21199
…word forgot password page wrong css used to make it vertially aling middle magento#21162
[pangolin] MQE-1430: [2.2.x] Limit allowed bin/magento commands to specific list (MTF)
… customer to the Recent Orders magento#21224 - Merge Pull Request magento#21224 from eduard13/magento2:2.2-develop-PR-port-21100 - Merged commits: 1. 67ef38c
MAGETWO-96001: Update FedEx Shipping Dates behavior in Tracking Popup
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#20866: [Backport] Issue magento#20380 fixed for 2.2 (by @maheshWebkul721) Fixed GitHub Issues: - magento#20380: Get Shipping Method as object from order instance gives undefined index. (reported by @maheshWebkul721) has been fixed in magento#20866 by @maheshWebkul721 in 2.2-develop branch Related commits: 1. c495f31
# Conflicts: # app/code/Magento/Catalog/Test/Mftf/Data/ProductData.xml
…ibute programmatically magento#21437 - Merge Pull Request magento#21437 from Nazar65/magento2:backport-issue-19983 - Merged commits: 1. b635e09 2. 97b8f5f
[TSG-CSL3] For 2.2 (pr22)
[TSG] MFTF for 2.2 (pr15) (2.2-develop)
…to#21423 - Merge Pull Request magento#21423 from eduard13/magento2:2.2-develop-PR-port-21020 - Merged commits: 1. abc3e7c 2. 4b2c1b4 3. 730987f
…ibute programmatically magento#21437
Accepted Public Pull Requests: - magento#21423: [Backport] Make the module list more deterministic (by @eduard13) - magento#21437: [Backport]-issue-195196 Can't upload customer Image attribute programmatically (by @Nazar65) Fixed GitHub Issues: - magento#8479: Sequence of module load order should be deterministic (reported by @scottsb) has been fixed in magento#21423 by @eduard13 in 2.2-develop branch Related commits: 1. abc3e7c 2. 4b2c1b4 3. 730987f - magento#16116: Modules sort order in config.php is being inconsistent when no changes being made (reported by @comdiler) has been fixed in magento#21423 by @eduard13 in 2.2-develop branch Related commits: 1. abc3e7c 2. 4b2c1b4 3. 730987f - magento#19983: Can't work customer Image attribute programmatically (reported by @cygnetampatel) has been fixed in magento#21437 by @Nazar65 in 2.2-develop branch Related commits: 1. b635e09 2. 97b8f5f
Added Squiz.Operators.ValidLogicalOperators rule
ansari-ziyaurrahman
force-pushed
the
2.2-develop-PR-port-22258
branch
2 times, most recently
from
a452da4 to
8c1db6c
Compare
ansari-ziyaurrahman
force-pushed
the
2.2-develop-PR-port-22258
branch
from
8c1db6c to
cb910d6
Compare
|
There are more commites in this PR, So I am close and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#22258
Description
There are variables available for tooltip customization. This commit fixes an issue
on tablet devices when trying to use them.
Manual testing scenarios
Open
Magento/blank/Magento_Checkout/web/css/source/module/checkout/_tooltip.lessfile and change the values of the tooltip variables as follows (Usually we do this via theme, but it's for testing purpose only):Navigate to checkout and chec the new styles of field tooltips
Set the width to
768pxand check them again:Contribution checklist (*)