Qty box visibility issue in wishlist when product is out of stock #22381

ansari-ziyaurrahman · 2019-04-17T06:30:07Z

Description (*)

Magento 2.3.x
Magento 2.2.x

Qty box should not be displayed in the wishlist if an added product is out of stock.

Fixed Issues (if relevant)

magento/magento2#<issue_number>: Issue title
...

Manual testing scenarios (*)

Set out of stock product display as a front end from admin configuration by below steps
Stores >> Setting >> Configuration >> Catalog >> Inventory >> Display Out of Stock Products set Yes
Login as a customer in frontend
Add out of stock product into wishlist
Review the product in My Wish List section in frontend where qty box is displayed for out of stock product.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

m2-assistant · 2019-04-17T06:30:09Z

Hi @ansari-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-engcom-team · 2019-04-17T06:45:54Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4770 has been created to process this Pull Request

soleksii · 2019-04-17T08:11:40Z

✔️ QA Passed

Before:

After:

kalpmehta

Any reason why Qty box should not be displayed if the product is not Saleable? There might be a case when customer want to see how many Qty of the product they added to wishlist, even though the product is out of stock.

ansari-ziyaurrahman · 2019-04-17T09:49:22Z

Hi @kalpmehta,
Thanks for reviewing.
Yes, There might be a case so customer shows Qty box even though the product is out of stock.
But I have not found any condition related to this. When Product is out of stock than "Add to cart" button is not displayed so I have updated the code on based on that condition. When Product is out of stock then also Qty box is in Editable mode, We should remove it or disabled qty box when product is out of stock.
Please let me know your through. If you need to do any change here.
Thank you.

kalpmehta · 2019-04-17T18:07:50Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-04-17T18:07:53Z

Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-04-17T18:08:47Z

Hi @kalpmehta, here is your new Magento instance.
Admin access: https://pr-22381.instances.magento-community.engineering/admin
Login: admin Password: 123123q

kalpmehta · 2019-04-17T18:19:54Z

@ansari-krish Yes, can you please disable the Comment and Qty fields as it's anyway not editable when the product is not Saleable? Thanks

ansari-ziyaurrahman · 2019-04-18T05:35:37Z

@ansari-krish Yes, can you please disable the Comment and Qty fields as it's anyway not editable when the product is not Saleable? Thanks

Hi @kalpmehta,
I have made changes as per your suggestions, Please review it.
Thanks

kalpmehta · 2019-04-18T05:35:43Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-04-18T05:35:47Z

Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-04-18T05:36:40Z

Hi @kalpmehta, here is your new Magento instance.
Admin access: https://pr-22381.instances.magento-community.engineering/admin
Login: admin Password: 123123q

kalpmehta · 2019-04-18T05:51:45Z

app/code/Magento/Wishlist/view/frontend/templates/item/column/cart.phtml

-/** @var \Magento\Wishlist\ViewModel\AllowedQuantity $viewModel */
-$viewModel = $block->getData('allowedQuantityViewModel');
-$allowedQty = $viewModel->setItem($item)->getMinMaxQty();
+$allowedQty = $block->getMinMaxQty();


@ansari-krish Do you have to change this code for this PR?

Can you please revert it then? thanks!

git issue is resolved, Please review now.

magento-engcom-team · 2019-04-18T06:40:37Z

Hi @kalpmehta, thank you for the review.
ENGCOM-4770 has been created to process this Pull Request

soleksii · 2019-04-18T08:41:48Z

✔️ QA Passed

Result:

m2-assistant · 2019-04-20T17:22:15Z

Hi @ansari-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

… of stock #22381

Qty box visibility issue in whishlist when product is out of stock

4fb0be0

magento-engcom-team added Area: Frontend Component: Wishlist Release Line: 2.3 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Apr 17, 2019

ansari-ziyaurrahman requested review from ihor-sviziev and swnsma April 17, 2019 06:34

ihor-sviziev approved these changes Apr 17, 2019

View reviewed changes

ghost assigned ihor-sviziev Apr 17, 2019

ghost added the Progress: ready for testing label Apr 17, 2019

soleksii self-assigned this Apr 17, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 17, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 17, 2019

kalpmehta requested changes Apr 17, 2019

View reviewed changes

ghost assigned kalpmehta Apr 17, 2019

ghost added Progress: needs update and removed Progress: extended testing labels Apr 17, 2019

ansari-ziyaurrahman requested a review from kalpmehta April 17, 2019 10:28

disabled comment and qty field when out of stock

408e386

kalpmehta reviewed Apr 18, 2019

View reviewed changes

Resolved git conflict

be34f65

ansari-ziyaurrahman force-pushed the patch-whishlist-qty-issue branch from 259eaa1 to be34f65 Compare April 18, 2019 06:30

Merge branch '2.3-develop' into patch-whishlist-qty-issue

a25a99a

ansari-ziyaurrahman requested a review from kalpmehta April 18, 2019 06:37

kalpmehta approved these changes Apr 18, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 18, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 18, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 18, 2019

p-bystritsky self-assigned this Apr 18, 2019

ghost added Progress: accept and removed Progress: extended testing labels Apr 18, 2019

magento-engcom-team added the Award: bug fix label Apr 18, 2019

magento-engcom-team merged commit a25a99a into magento:2.3-develop Apr 20, 2019

magento-engcom-team pushed a commit that referenced this pull request Apr 20, 2019

ENGCOM-4770: Qty box visibility issue in wishlist when product is out…

c05ca7c

… of stock #22381

magento-engcom-team added this to the Release: 2.3.2 milestone Apr 20, 2019

niravkrish mentioned this pull request Apr 24, 2019

[Backport] Qty box visibility issue in wishlist when product is out of stock #22473

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qty box visibility issue in wishlist when product is out of stock #22381

Qty box visibility issue in wishlist when product is out of stock #22381

ansari-ziyaurrahman commented Apr 17, 2019 •

edited

Loading

m2-assistant bot commented Apr 17, 2019

magento-engcom-team commented Apr 17, 2019

soleksii commented Apr 17, 2019

kalpmehta left a comment •

edited

Loading

ansari-ziyaurrahman commented Apr 17, 2019

kalpmehta commented Apr 17, 2019

magento-engcom-team commented Apr 17, 2019

magento-engcom-team commented Apr 17, 2019

kalpmehta commented Apr 17, 2019

ansari-ziyaurrahman commented Apr 18, 2019

kalpmehta commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

kalpmehta Apr 18, 2019

ansari-ziyaurrahman Apr 18, 2019

kalpmehta Apr 18, 2019

ansari-ziyaurrahman Apr 18, 2019

ansari-ziyaurrahman Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

soleksii commented Apr 18, 2019

m2-assistant bot commented Apr 20, 2019

Qty box visibility issue in wishlist when product is out of stock #22381

Qty box visibility issue in wishlist when product is out of stock #22381

Conversation

ansari-ziyaurrahman commented Apr 17, 2019 • edited Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Apr 17, 2019

magento-engcom-team commented Apr 17, 2019

soleksii commented Apr 17, 2019

kalpmehta left a comment • edited Loading

Choose a reason for hiding this comment

ansari-ziyaurrahman commented Apr 17, 2019

kalpmehta commented Apr 17, 2019

magento-engcom-team commented Apr 17, 2019

magento-engcom-team commented Apr 17, 2019

kalpmehta commented Apr 17, 2019

ansari-ziyaurrahman commented Apr 18, 2019

kalpmehta commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

magento-engcom-team commented Apr 18, 2019

kalpmehta Apr 18, 2019

Choose a reason for hiding this comment

ansari-ziyaurrahman Apr 18, 2019

Choose a reason for hiding this comment

kalpmehta Apr 18, 2019

Choose a reason for hiding this comment

ansari-ziyaurrahman Apr 18, 2019

Choose a reason for hiding this comment

ansari-ziyaurrahman Apr 18, 2019

Choose a reason for hiding this comment

magento-engcom-team commented Apr 18, 2019

soleksii commented Apr 18, 2019

m2-assistant bot commented Apr 20, 2019

ansari-ziyaurrahman commented Apr 17, 2019 •

edited

Loading

kalpmehta left a comment •

edited

Loading