Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Qty box visibility issue in wishlist when product is out of stock #22473

Merged

Conversation

niravkrish
Copy link
Contributor

Original Pull Request

#22381

Description (*)

Magento 2.3.x
Magento 2.2.x

Qty box should not be displayed in the wishlist if an added product is out of stock.

Manual testing scenarios (*)

  1. Set out of stock product display as a front end from admin configuration by below steps
    Stores >> Setting >> Configuration >> Catalog >> Inventory >> Display Out of Stock Products set Yes
  2. Login as a customer in frontend
  3. Add out of stock product into wishlist
  4. Review the product in My Wish List section in frontend where qty box is displayed for out of stock product.
    Screenshot from 2019 04 17 11 50 01

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 24, 2019

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ronak2ram ronak2ram self-requested a review April 24, 2019 06:34
@ronak2ram ronak2ram self-assigned this Apr 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-4817 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 25, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants