Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Dependency on Backup Settings Configuration #22475

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fixed Dependency on Backup Settings Configuration #22475

merged 1 commit into from
Apr 26, 2019

Conversation

keyurk-emipro
Copy link
Contributor

Description (*)

Fixed Dependency on Backup Settings Configuration

Fixed Issues (if relevant)

  1. Incomplete Dependency on Backup Settings Configuration #22474: Incomplete Dependency on Backup Settings Configuration
  2. ...

Manual testing scenarios (*)

  1. Go to Store > Configuration > System > Advanced > Backup Settings
  2. Enable Backup => Yes
  3. Enable Scheduled Backup => Yes
  4. Enable Backup => No
  5. Now all fields are hidden with proper dependencies.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 24, 2019

Hi @keyuremipro. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@keyurk-emipro
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @keyuremipro. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @keyuremipro, here is your new Magento instance.
Admin access: https://pr-22475.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned orlangur Apr 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4815 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 24, 2019
@soleksii
Copy link

✔️ QA Passed

@Nazar65 Nazar65 self-assigned this Apr 25, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 26, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 60e862f into magento:2.3-develop Apr 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @keyuremipro, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 26, 2019
@sidolov
ENGCOM-4815: Fixed Dependency on Backup Settings Configuration #22475
d55e677
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 26, 2019
@keyurk-emipro keyurk-emipro mentioned this pull request Apr 26, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@Nazar65 Nazar65

@soleksii soleksii

Labels
Community Insider : Emipro community-insider-contribution Component: Backup Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@keyurk-emipro @magento-engcom-team @soleksii @orlangur @Nazar65