Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed Dependency on Backup Settings Configuration #22499

Conversation

keyurk-emipro
Copy link
Contributor

Original Pull Request

#22475

Description (*)

Fixed Dependency on Backup Settings Configuration

Fixed Issues (if relevant)

  1. Incomplete Dependency on Backup Settings Configuration #22474: Incomplete Dependency on Backup Settings Configuration
  2. ...

Manual testing scenarios (*)

  1. Go to Store > Configuration > System > Advanced > Backup Settings
  2. Enable Backup => Yes
  3. Enable Scheduled Backup => Yes
  4. Enable Backup => No
  5. Now all fields are hidden with proper dependencies.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sorry, something went wrong.

@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @keyuremipro. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4829 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @keyuremipro, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 26, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…tion #22499
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants