Resolved issue coupon codes don't work anymore #18183

[this-adarsh]

Description (*)

Fixed Issues (if relevant)

1. Magento 2.2.6 coupon codes don't work anymore #18183: Issue title
2. coupon codes don't work anymore

Manual testing scenarios (*)

1. Create a coupon code.
2. Set from & to date 2018 to 2088 respectively.
3. Apply coupon code.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @this-adarsh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[this-adarsh]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @this-adarsh. Thank you for your request. I'm working on Magento instance for you

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @this-adarsh, here is your new Magento instance.
Admin access: https://pr-22718.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[ronak2ram]

Hi @this-adarsh, please, sign CLA, otherwise, we can't process your pull request

[rogyar]

@ronak2ram please note that changing a DB column type is backward incompatible change

[rogyar]

For QA.
I've mentioned that changing the DB column is a backward incompatible change. However, in this case technically it should not bring problems since the timestamp -> datetime types in MySQL are almost identical. In terms with Magento persistence layer, there's no difference as well.

Timestamps in MySQL are generally used to track changes to records the coupon expiration date is not the case. So I believe we should use datetime here. Especially considering the fact that this change fixes the future date issue.

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-5086 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @this-adarsh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.