Update expires_at column type from table admin_user_expiration in ord…

[SinpietruAdrian]

Description

New admin account is disabled after a login attempt is made if the account's expiration date is greater than 2038. This is fixed by updating the expires_at column type from the admin_user_expiration table to datetime.

Fixed Issues

#34463

Manual testing scenarios

Create an admin user with an Expiration Date greater than 2038 and attempt a login to the admin area with this newly created user.

[m2-assistant]

Hi @SinpietruAdrian. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

FYI, this is a similar fix as #22718 that solved a similar problem with the year 2037/2038 in coupon codes as described over here

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[SinpietruAdrian]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@SinpietruAdrian @hostep,
Good catch!
It looks like we should migrate all fields with "timestamp" to the "datetime".
What do you think?

[hostep]

@ihor-sviziev: yeah probably, I guess. But should it happen in scope of this PR?
I "only" find 146 occurrences in the entire codebase 😛

[ihor-sviziev]

@hostep, as to me it looks like a quite simple fix. It's better to fix all places at once than fixing all places separately

[hostep]

@ihor-sviziev: I've just briefly discussed this with Adrian (a colleague of mine) during our daily standup, and we decided that it is out of scope of this PR to change all the fields in the entire codebase, because there could be unwanted consequences due to how timezones are handled. In this particular case, the timezone is not that important.

I've opened a new issue to investigate all other usages of those timestamp fields in the codebase: #34478

Is this ok for you guys?

[ihor-sviziev]

Hi @SinpietruAdrian,
Could you sign the adobe CLA?

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[m2-assistant]

Hi @SinpietruAdrian, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[SinpietruAdrian]

I've signed the CLA, closed/reopened the PR but it's still failing. Anything else I should do?

[ihor-sviziev]

Hi @SinpietruAdrian,
Please add your commit author's email to your github account.

[engcom-Bravo]

@SinpietruAdrian Please sign CLA. We could not merge PR without that

[engcom-Lima]

Hi @SinpietruAdrian ,

Thank you for your contribution!

We are not able to proceed further on this PR as you have not signed the Adobe CLA yet. Hence closing this PR.

Please reopen and update if you wish to continue.

Thank you for your contribution!

[hostep]

Looks like this got fixed by core devs in: 97f85b9 (which is included in Magento 2.4.5)