Catch throwables in mview updating

[QuentinFarizon]

2.2 : #23124
2.3 : #23125

Description (*)

Certain type of runtime exception weren't caught during mview updating, which caused some mview to be stuck in "processing" mode.
Refer to #23054 for more detail about the issue.

This modification is very similar to the one made here : 5927a75

Fixed Issues (if relevant)

#23054

Manual testing scenarios (*)

• make an mview updating crash with a Throwable (not an Exception)
• process ends, mview is still in 'processing' in database
• it is never picked up again

Questions or comments

This does not prevent against all types of crashes (like process out of memory or server stop abruptly, so it is only a step in making indexing crons more resilient

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @QuentinFarizonAfrimarket. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[orlangur]

@QuentinFarizonAfrimarket all changes must be applied to 2.3-develop first.

If they are already fixed there, instead of creating new commits appropriate ones should be backported.

[QuentinFarizon]

Hello @orlangur ok thanks, I have opened the PR on 2.3 also : #23125

[VladimirZaets]

Hi @QuentinFarizonAfrimarket . The branch 2.2-develop will be closed for contribution from July 15, 2019. Please finish all your Pull Requests till this date, otherwise, they will be closed.
Thanks for collaboration.

[orlangur]

@VladimirZaets any idea why #23125 is still not merged having approval since Jun 5th?

[QuentinFarizon]

I was indeed waiting for #23125 to be merged to bring changes here, but with the due date being today I have pushed a version which fixes static tests, in the hope it will be taken in 2.2-develop

[orlangur]

Great job @QuentinFarizonAfrimarket! Please re-resolve conflict though :)

[QuentinFarizon]

Sorry, should be better like this :)

[orlangur]

@QuentinFarizonAfrimarket definitely ;) A small thing left, unit test needs to be adjusted.

[VladimirZaets]

Hi @QuentinFarizonAfrimarket.
The next 2.2 release will be the last of functional releases.
Due to it, we are closing 2.2-develop for contribution.
Thanks for collaboration.

[m2-assistant]

Hi @QuentinFarizonAfrimarket, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.