Catch throwables in mview updating #23125
Conversation
|
Hi @QuentinFarizonAfrimarket. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
| throw $exception; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private function executeAction($action, $currentVersionId, $lastVersionId) { |
There was a problem hiding this comment.
Typehints, please, and declare strict types should also work, I believe.
There was a problem hiding this comment.
@QuentinFarizonAfrimarket please add declare(strict types) on top and if builds will be green - squash into a single commit. If not, don't add such line and just squash.
There was a problem hiding this comment.
Done, tests pass with strict type
ghost
assigned 
QuentinFarizon
force-pushed
the
mview_catch_throwables2.3
branch
3 times, most recently
from
51a2019 to
13e57f3
Compare
|
I would honestly keep it as 2 separate commits, they do 2 different things (one bug fix, another is cleanup), so it makes sense to keep them separate in my opinion. |
|
@hostep ah, ok, I didn't notice bugfix + refactoring are separated, thought that was in first commit and then some adjustments. |
|
Hi @orlangur, thank you for the review. |
|
@QuentinFarizonAfrimarket thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Yes it was my intention to separate behaviour and refactoring :) |
QuentinFarizon
force-pushed
the
mview_catch_throwables2.3
branch
from
13e57f3 to
ba4dff7
Compare
|
QA passed. |
|
Hi @QuentinFarizonAfrimarket, thank you for your contribution! |
sidolov
added
the
Auto-Tests: Not Covered
2.2 : #23124
2.3 : #23125
Description
Certain type of runtime exception weren't caught during mview updating, which caused some mview to be stuck in "processing" mode.
Refer to #23054 for more detail about the issue.
This modification is very similar to the one made here : 5927a75
Fixed Issues
#23054
Manual testing scenarios
make an mview updating crash with a Throwable (not an Exception)
process ends, mview is still in 'processing' in database
it is never picked up again
Questions or comments
This does not prevent against all types of crashes (like process out of memory or server stop abruptly, so it is only a step in making indexing crons more resilient
Contribution checklist (*)