Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#26749: Product flat table - Incorrect data #27222

Closed
wants to merge 6 commits into from
Closed

magento/magento2#26749: Product flat table - Incorrect data #27222

wants to merge 6 commits into from

Conversation

engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie commented Mar 10, 2020 •
edited by engcom-Echo
Loading

Description (*)

Fixed product data has been inserted into an incorrect flat table. Covered by test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Product flat table - Incorrect data #26749: Product flat table - Incorrect data

Manual testing scenarios (*)

Please see #26749

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 10, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

dmytro-ch
dmytro-ch requested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @engcom-Charlie! Could you please also update the unit test?
Thank you!

@ghost ghost assigned dmytro-ch Mar 10, 2020
@engcom-Charlie
Copy link
Contributor Author

Hello @engcom-Charlie! Could you please also update the unit test?
Thank you!

Hello @dmytro-ch, yes I'll do it.

@engcom-Charlie
Copy link
Contributor Author

Hello @ihor-sviziev, could You please make a review on this PR?

dmytro-ch
dmytro-ch reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @engcom-Charlie, sorry for the late reply. I've missed the review request notification for some reason.
The result looks good to me.
Could you please just check the minor CR notice?

Thank you!

app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Row.php Outdated Show resolved Hide resolved
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Mar 26, 2020
dmytro-ch
dmytro-ch previously approved these changes Mar 26, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7211 has been created to process this Pull Request

@engcom-Echo engcom-Echo self-assigned this Apr 2, 2020
@engcom-Echo
Copy link
Contributor

Hi, @engcom-Charlie will resolve conflict.

@engcom-Alfa engcom-Alfa self-assigned this Apr 2, 2020
engcom-Alfa
engcom-Alfa requested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @engcom-Charlie. Could you resolve merge conflicts?
Thanks!

@ghost ghost dismissed dmytro-ch’s stale review April 2, 2020 11:01

Pull Request state was updated. Re-review required.

@engcom-Echo
Copy link
Contributor

engcom-Echo commented May 25, 2020 •
edited
Loading

Closed PR because this issue has already been fixed: #27365

@m2-assistant
Copy link

m2-assistant bot commented May 25, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@dmytro-ch dmytro-ch dmytro-ch left review comments

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Catalog Progress: needs update Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product flat table - Incorrect data
5 participants
@engcom-Charlie @magento-engcom-team @engcom-Echo @dmytro-ch @engcom-Alfa