Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 16315: Product save with onthefly index ignores website assignments #27365

Merged
merged 6 commits into from
Apr 1, 2020
Merged

Fix issue 16315: Product save with onthefly index ignores website assignments #27365

merged 6 commits into from
Apr 1, 2020

Conversation

tna274
Copy link
Contributor

@tna274 tna274 commented Mar 19, 2020

Description (*)

Fix issue 16315: Product save with onthefly index ignores website assignments

Related Pull Requests

Fixed Issues (if relevant)

  1. Product save with onthefly index ignores website assignments #16315: Product save with onthefly index ignores website assignments

Manual testing scenarios (*)

  1. Enable "Use Flat Catalog Product"
  2. Create multiple stores
  3. Enable "Update On Save" for Product Flat Data indexer
  4. Remove all website assignments from a product
  5. Save the product
  6. Check Flat table

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @tna274. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@edenduong edenduong self-assigned this Mar 20, 2020
@edenduong edenduong added Award: bug fix Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Mar 20, 2020
edenduong
edenduong requested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Magento Definition Of Done https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing_dod.html, all the code changes should be covered by Automation Test. Could you please covered this PR by Unit/Integration Test?

@edenduong edenduong added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Mar 22, 2020
edenduong
edenduong requested changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment @tna274

app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Row.php Outdated Show resolved Hide resolved
edenduong
edenduong approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution !

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7179 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Mar 27, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Mar 30, 2020
@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

magento-engcom-team pushed a commit that referenced this pull request Apr 1, 2020
@slavvka
ENGCOM-7179: Fix issue 16315: Product save with onthefly index ignore…
db0f733 
…s website assignments #27365
@magento-engcom-team magento-engcom-team merged commit 67d5bef into magento:2.4-develop Apr 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 1, 2020

Hi @tna274, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team mentioned this pull request May 1, 2020
Closed
This was referenced May 25, 2020
Closed
Closed
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenduong edenduong edenduong approved these changes

Assignees

@edenduong edenduong

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tna274 @magento-engcom-team @engcom-Alfa @engcom-Echo @edenduong