-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order Invoice create page doesn't show order items properly for bundle product Fixed Issue #27350 #27602
Order Invoice create page doesn't show order items properly for bundle product Fixed Issue #27350 #27602
Conversation
Hi @gauravagarwal1001. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento instance for you |
@magento give me 2.4-develop instance |
Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @gauravagarwal1001, here is your new Magento instance. |
@magento give me 2.4-develop instance |
Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @gauravagarwal1001, here is your Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gauravagarwal1001, thanks for the pull request! Could you update this PR with the mainline? Also, all the PRs now must have test coverage, it would be nice to add an MFTF to check if the items are displayed.
Let me know if you need any help with this.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for contributor's response
Hi @gauravagarwal1001, can you please merge the conflict and cover your changes by autotest? Otherwise, we can't proceed with your PR. |
@magento run Functional Tests B2B |
Hi @gabrieldagama, thank you for the review.
|
✔️ QA Passed Manual testing scenario:
Before: ✖️ Items are missing After: ✔️ The bundle product is displayed with a list of options Also, was tested with a few bundle products with different types of options in order, and everything works as expected. |
@magento run all tests |
Hi @gauravagarwal1001, thank you for your contribution! |
Fixed Issue #27350
Fixed Issues (if relevant)
While crating invoice for bundle product doesn't show its child items.
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)