-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF Test Coverage: #27350 Order Invoice display for Bundled Items #29708
MFTF Test Coverage: #27350 Order Invoice display for Bundled Items #29708
Conversation
updating magento
Hi @saphaljha. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests needs to be fixed
app/code/Magento/Sales/Test/Mftf/Section/AdminInvoiceItemsSection.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the issues I've noticed in your test.
...e/Magento/Bundle/Test/Mftf/Test/StorefrontBundlePlaceOrderWithMultipleOptionsSuccessTest.xml
Outdated
Show resolved
Hide resolved
...e/Magento/Bundle/Test/Mftf/Test/StorefrontBundlePlaceOrderWithMultipleOptionsSuccessTest.xml
Outdated
Show resolved
Hide resolved
...e/Magento/Bundle/Test/Mftf/Test/StorefrontBundlePlaceOrderWithMultipleOptionsSuccessTest.xml
Outdated
Show resolved
Hide resolved
app/code/Magento/Sales/Test/Mftf/Section/AdminInvoiceItemsSection.xml
Outdated
Show resolved
Hide resolved
@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B |
@saphaljha Could you make sure that amended selectors are correct, please? |
Yes, but after merging this PR #27602 |
After reviewing the failure reports, I'm pretty sure that the selector I asked you to change to be unique across the Panel fails. Could you confirm why? |
I would like you to check this pull request and issue, in this issue you will see that on new invoice page the bundle items are not showing as expected, so I have created the MFTF for this pull request. so after merging the below pull request this test will success. hope this is clear. |
Hi @saphaljha, unfortunately, we can't proceed with your PR with test coverage for separate PR. We can only proceed with one PR with fix and test coverage. |
Hi @saphaljha, I've applied your MFTF to PR with a fix. So I close this PR. |
Hi @saphaljha, thank you for your contribution! |
Description (*)
I have covered MFTF
Related Pull Requests
#27602
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)