Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF Test Coverage: #27350 Order Invoice display for Bundled Items #29708

Closed

Conversation

saphaljha
Copy link
Contributor

Description (*)

I have covered MFTF

Related Pull Requests

#27602

Fixed Issues (if relevant)

  1. Fixes Order Invoice create page doesn't show order items properly for bundle product #27350

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2020

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@saphaljha
Copy link
Contributor Author

@magento run all tests

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 21, 2020
Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests needs to be fixed

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the issues I've noticed in your test.

@ghost ghost assigned lbajsarowicz Aug 22, 2020
@lbajsarowicz lbajsarowicz changed the title Covered mftf for issue #27350 MFTF Test Coverage: #27350 Order Invoice display for Bundled Items Aug 22, 2020
@lbajsarowicz
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@lbajsarowicz
Copy link
Contributor

@saphaljha Could you make sure that amended selectors are correct, please?

@saphaljha
Copy link
Contributor Author

@saphaljha Could you make sure that amended selectors are correct, please?

Yes, but after merging this PR #27602

@lbajsarowicz
Copy link
Contributor

After reviewing the failure reports, I'm pretty sure that the selector I asked you to change to be unique across the Panel fails. Could you confirm why?

@saphaljha
Copy link
Contributor Author

I would like you to check this pull request and issue, in this issue you will see that on new invoice page the bundle items are not showing as expected, so I have created the MFTF for this pull request. so after merging the below pull request this test will success.
#27602

hope this is clear.

@engcom-Charlie
Copy link
Contributor

Hi @saphaljha, unfortunately, we can't proceed with your PR with test coverage for separate PR. We can only proceed with one PR with fix and test coverage.
Thank you for your collaboration.

@engcom-Charlie engcom-Charlie self-assigned this Sep 3, 2020
@engcom-Charlie
Copy link
Contributor

Hi @saphaljha, I've applied your MFTF to PR with a fix. So I close this PR.

@m2-assistant
Copy link

m2-assistant bot commented Sep 3, 2020

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: MFTF test coverage Component: Bundle Component: Sales Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Invoice create page doesn't show order items properly for bundle product
6 participants