Fix for Issue #278 (Import -> Stores with large amount of Configurable Products) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Attributes. _loadSkuSuperAttributeValues() is given parameters and a foreach loop creates the productIds needed for the current bunch. The conversion From Sku to Id is duplicated later in save(), but I felt it is best to do the conversion here then let the DB do the work. This fix is based off of a module rewrite for EE 1.12 and has not been tested on Mage2. It should work though, That Module successfully imported 700,000 Simple Products and many Configurable Products. Most of the Configurable Products having 3 super_attributes. Signed-off-by: Steven Hoffman <s.hoffman@harapartners.com>
|
Hello s-hoffman, |
magento-team
added a commit
that referenced
this pull request
Mar 7, 2014
* Cache: * Implemented depersonalization of private content generation * Implemented content invalidation * Added Edge Side Includes (ESI) support * Added a built-in caching application * GitHub requests: * [#454](#454) -- Allow to specify list of IPs in a body on maintenance.flag which will be granted access even if the flag is on * [#204](#204) -- Mage_ImportExport: Exporting configurable products ignores multiple configurable options * [#418](#418) -- Echo vs print * [#419](#419) -- Some translation keys are not correct. * [#244](#244) -- Retrieve base host URL without path in error processor * [#411](#411) -- Missed column 'payment_method' of table 'sales_flat_quote_address' * [#284](#284) -- Fix for Issue #278 (Import -> Stores with large amount of Configurable Products) * Fixed bugs: * Fixed an issue where Mage_Eav_Model_Entity_Type::fetchNewIncrementId() did not rollback on exception * Fixed an issue where a category containing more than 1000 products could not be saved * Fixed inappropriate error messages displayed during installation when required extensions were not installed * Fixed synopsis of the install.php script * Fixed an issue where the schedule of recurring payments was not displayed in the shopping cart * Modularity improvements: * Introduced the OfflinePayments module - a saparate module for offline payment methods * Added the ability to enable/disable the Paypal module * Moved the framework part of the Locale functionality from the Core module to library * The Locale logic was split among appropriate classes in library, according to their responsibilities * Removed the deprecated DHL functionality * Introduced the OfflineShipping module for offline shipping carrier functionality: Flatrate, Tablerate, Freeshipping, Pickup * Introduced a separate module for the DHL shipping carrier * Introduced a separate module for the Fedex shipping carrier * Introduced a separate module for the UPS shipping carrier * Introduced a separate module for the USPS shipping carrier * Framework Improvements: * Added the ability to intercept internal public calls * Added the ability to access public interface of the intercepted object * Added a static integrity test for plugin interface validation * Added support for both class addressing approaches in DI: with and without slash ("\") at the beginning of a class name * Customer Service usage: * Refactored the Customer module blocks and controllers to use customer service layer * Security: * Introduced the ability to hash a password with a random salt of default length (32 chars) by the encryption library * Utilized a random salt of default length for admin users, and frontend customers
|
@s-hoffman, the team resolved this issue and we have just released it in dev68. Thank you for reporting this to us! Please keep helping us make Magento better! |
magento-team
pushed a commit
that referenced
this pull request
May 15, 2015
[DRAGONS] M2 GitHub Update (version 0.74.0-beta8)
magento-team
pushed a commit
that referenced
this pull request
Jan 24, 2016
[Vanilla] Bug fixes & tasks
mmansoor-magento
pushed a commit
that referenced
this pull request
Aug 26, 2016
[Mavericks] Merge Domain Functional Bamboo Plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is for Stores with large amounts of Products and Configurable Attributes.
_loadSkuSuperAttributeValues() is given parameters and a foreach loop creates the productIds needed for the current bunch.
The conversion From Sku to Id is duplicated later in save(), but I felt it is best to do the conversion here then let the DB do the work. (Cheap Hash Lookups.)
This fix is based off of a module rewrite for EE 1.12 and has not been tested on Mage2. It should work though, That Module successfully imported 700,000 Simple Products and many (80K~ish) Configurable Products. Most of the Configurable Products having 3 super_attributes.
It has also been tested by @barbazul on CE 1.7.0.2. And it worked.
The changes could be slightly cleaner. To do so I would have to had made a bigger change to the structure of the Module. This version of the fix is conceptually cleaner.
Whatever tests you currently have for testing Import -> Products will work to cover this Fix also.
Signed-off-by: Steven Hoffman s.hoffman@harapartners.com