-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Refactoring admin url rewrite multiple storeviews product import with config turned off test #28457
Merged
magento-engcom-team
merged 6 commits into
magento:2.4-develop
from
kate-kyzyma:Refactoring-AdminUrlRewriteMultipleStoreviewsProductImportWithConfigTurnedOffTest
Jun 19, 2020
Merged
MFTF: Refactoring admin url rewrite multiple storeviews product import with config turned off test #28457
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e792109
Updating the test
kate-kyzyma 9af550a
Merge branch '2.4-develop' into Refactoring-AdminUrlRewriteMultipleSt…
kate-kyzyma 1b6211e
Updating the test
kate-kyzyma 5412bd7
Merge branch '2.4-develop' into Refactoring-AdminUrlRewriteMultipleSt…
kate-kyzyma a713517
Change stepKey name
kate-kyzyma 1775728
Merge branch '2.4-develop' into Refactoring-AdminUrlRewriteMultipleSt…
kate-kyzyma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
...ento/Catalog/Test/Mftf/ActionGroup/AdminChangeCategoryNameOnStoreViewLevelActionGroup.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| --> | ||
|
|
||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="AdminChangeCategoryNameOnStoreViewLevelActionGroup"> | ||
| <annotations> | ||
| <description>Updates the Category Name for proper Store View.</description> | ||
| </annotations> | ||
| <arguments> | ||
| <argument name="categoryName" type="string"/> | ||
| </arguments> | ||
|
|
||
| <uncheckOption selector="{{AdminCategoryBasicFieldSection.categoryNameUseDefault}}" stepKey="uncheckUseDefaultValueENStoreView"/> | ||
| <fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{categoryName}}" stepKey="changeNameField"/> | ||
| <click selector="{{AdminCategorySEOSection.SectionHeader}}" stepKey="clickOnSectionHeader"/> | ||
| </actionGroup> | ||
| </actionGroups> | ||
23 changes: 23 additions & 0 deletions
23
...agento/UrlRewrite/Test/Mftf/ActionGroup/AdminSearchUrlRewriteByRequestPathActionGroup.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| --> | ||
|
|
||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="AdminSearchUrlRewriteByRequestPathActionGroup" extends="AdminSearchAndSelectUrlRewriteInGridActionGroup"> | ||
| <annotations> | ||
| <description>EXTENDS: SearchAndSelectUrlRewrite. Removes 'clickOnRowSelectButton' and 'clickOnEditButton'.</description> | ||
| </annotations> | ||
| <arguments> | ||
| <argument name="requestPath" type="string"/> | ||
| </arguments> | ||
|
|
||
| <remove keyForRemoval="clickOnRowSelectButton"/> | ||
| <remove keyForRemoval="clickOnEditButton"/> | ||
| <remove keyForRemoval="waitForEditPageToLoad"/> | ||
| </actionGroup> | ||
| </actionGroups> |
22 changes: 22 additions & 0 deletions
22
...to/UrlRewrite/Test/Mftf/ActionGroup/AssertAdminRequestPathInUrlRewriteGrigActionGroup.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| --> | ||
|
|
||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="AssertAdminRequestPathInUrlRewriteGrigActionGroup"> | ||
| <annotations> | ||
| <description>Assert the requested path is shown in the URL Rewrite grid.</description> | ||
| </annotations> | ||
| <arguments> | ||
| <argument name="requestPath" type="string"/> | ||
| </arguments> | ||
|
|
||
| <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', requestPath)}}" | ||
| stepKey="seeValueInGrid"/> | ||
| </actionGroup> | ||
| </actionGroups> |
22 changes: 22 additions & 0 deletions
22
...ite/Test/Mftf/ActionGroup/AssertAdminRequestPathIsNotFoundInUrlRewriteGrigActionGroup.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| --> | ||
|
|
||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="AssertAdminRequestPathIsNotFoundInUrlRewriteGrigActionGroup"> | ||
| <annotations> | ||
| <description>Assert the requested path is not shown in the URL Rewrite grid.</description> | ||
| </annotations> | ||
| <arguments> | ||
| <argument name="requestPath" type="string"/> | ||
| </arguments> | ||
|
|
||
| <dontSeeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', requestPath)}}" | ||
| stepKey="valueIsNotShownInGrid"/> | ||
| </actionGroup> | ||
| </actionGroups> |
22 changes: 22 additions & 0 deletions
22
...nto/UrlRewrite/Test/Mftf/ActionGroup/AssertAdminTargetPathInUrlRewriteGrigActionGroup.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| --> | ||
|
|
||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="AssertAdminTargetPathInUrlRewriteGrigActionGroup"> | ||
| <annotations> | ||
| <description>Assert the target path is shown in the URL Rewrite grid.</description> | ||
| </annotations> | ||
| <arguments> | ||
| <argument name="targetPath" type="string"/> | ||
| </arguments> | ||
|
|
||
| <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Target Path', targetPath)}}" | ||
| stepKey="seeValueInGrid"/> | ||
| </actionGroup> | ||
| </actionGroups> |
22 changes: 22 additions & 0 deletions
22
...rite/Test/Mftf/ActionGroup/AssertAdminTargetPathIsNotFoundInUrlRewriteGrigActionGroup.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| --> | ||
|
|
||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="AssertAdminTargetPathIsNotFoundInUrlRewriteGrigActionGroup"> | ||
| <annotations> | ||
| <description>Assert the target path is not shown in the URL Rewrite grid.</description> | ||
| </annotations> | ||
| <arguments> | ||
| <argument name="targetPath" type="string"/> | ||
| </arguments> | ||
|
|
||
| <dontSeeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', targetPath)}}" | ||
| stepKey="valueIsNotShownInGrid"/> | ||
| </actionGroup> | ||
| </actionGroups> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stepKeycontains misleading information about the store view which is not actually the case in scope of the ActionGroup : )