Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Refactoring admin url rewrite multiple storeviews product import with config turned off test #28457

Merged
merged 6 commits into from
Jun 19, 2020
Merged

MFTF: Refactoring admin url rewrite multiple storeviews product import with config turned off test #28457

merged 6 commits into from
Jun 19, 2020

Conversation

kate-kyzyma
Copy link
Contributor

@kate-kyzyma kate-kyzyma commented Jun 1, 2020 •
edited
Loading

Description (*)

AdminUrlRewriteMultipleStoreviewsProductImportWithConfigTurnedOffTest is refactored according to the best practices followed by MFTF.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Run AdminUrlRewriteMultipleStoreviewsProductImportWithConfigTurnedOffTest in the local environment and verified the test runs successfully.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 1, 2020

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Catalog Component: UrlRewrite Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 1, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

@dmytro-ch dmytro-ch self-assigned this Jun 1, 2020
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise labels Jun 4, 2020
lbajsarowicz
lbajsarowicz reviewed Jun 7, 2020
View reviewed changes
...Magento/Catalog/Test/Mftf/ActionGroup/AdminChangeCategoryNameOnStoreViewLevelActionGroup.xml Outdated
<argument name="categoryName" type="string"/>
</arguments>

<uncheckOption selector="{{AdminCategoryBasicFieldSection.categoryNameUseDefault}}" stepKey="uncheckUseDefaultValueENStoreView"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stepKey contains misleading information about the store view which is not actually the case in scope of the ActionGroup : )

@ghost ghost assigned lbajsarowicz Jun 7, 2020
@kate-kyzyma
Copy link
Contributor Author

Hi @lbajsarowicz
Thanks for reviewing my test. I have fixed the issue.

@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

lbajsarowicz
lbajsarowicz previously approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Great job!

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7666 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jun 16, 2020
@kate-kyzyma
Merge branch '2.4-develop' into Refactoring-AdminUrlRewriteMultipleSt…
1775728 
…oreviewsProductImportWithConfigTurnedOffTest
@kate-kyzyma
Copy link
Contributor Author

Hi @engcom-Alfa
I have resolved the merge conflict.

Thanks.

@engcom-Alfa engcom-Alfa requested a review from lbajsarowicz June 16, 2020 13:51
lbajsarowicz
lbajsarowicz approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Great job, thank you for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7666 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Jun 17, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 17, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2020
@slavvka
ENGCOM-7666: MFTF: Refactoring admin url rewrite multiple storeviews …
8cf68cc 
…product import with config turned off test #28457
@magento-engcom-team magento-engcom-team merged commit da041a3 into magento:2.4-develop Jun 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2020

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kate-kyzyma kate-kyzyma deleted the Refactoring-AdminUrlRewriteMultipleStoreviewsProductImportWithConfigTurnedOffTest branch June 24, 2020 08:34
@Den4ik Den4ik mentioned this pull request Apr 20, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: UrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kate-kyzyma @dmytro-ch @magento-engcom-team @engcom-Alfa @engcom-Charlie @lbajsarowicz @slavvka