Replace repetitive actions with Action Groups in ProductsListWidgetTest

[kate-kyzyma]

Description (*)

The test is refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Run the test in the local environment and verified that it run successfully.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[kate-kyzyma]

@magento run all tests

[kate-kyzyma]

@magento run Functional Tests B2B

[kate-kyzyma]

@magento run all tests

[kate-kyzyma]

@magento run Functional Tests B2B, Functional Tests CE, Integration Tests, Unit Tests

[kate-kyzyma]

@magento run all tests

[kate-kyzyma]

@magento run Functional Tests EE

[kate-kyzyma]

@magento run Functional Tests B2B, Integration Tests

[eduard13]

@Den4ik those comments are added in order to preserve the stepKeys that were removed, since removing any stepKey is a backward incompatible change, as there might be some 3rd party tests that can rely on some step keys. So, by not preserving them, it means to not provide support for those tests that extend the current ones.

Thanks.

[Den4ik]

@eduard13, thanks for your comment.
I just want provide my opinion on this case.
I suggested to remove comments by 2 reasons:

1. Comments are add unnecessary information to execution output additionally to output from action groups
2. I saw in git history PRs that contain same backward incompatible changes and was merged.

Do you have examples of 3rd modules that rely on step keys?
I agree with adding comments if PR contains only removing some of steps, but when we moving all steps from Test file to action group we don't missing anything. It's just my opinion.

[eduard13]

@Den4ik, I totally agree with you regarding the 1st point, there is no doubt about that. As about already delivered similar PRs, could you please share some if you still have a reference to them?

Do you have examples of 3rd modules that rely on step keys?

Unfortunately not, but since MFTF allows this, then I don’t think we need to find some real examples.

but when we moving all steps from Test file to action group we don't missing anything.

In this case, the generated stepKey won’t be the same anymore, it will be suffixed(if I’m not wrong) by ActionGroup’s stepKey. So you’ll loose its reference.

Thank you.

[Den4ik]

@eduard13

could you please share some if you still have a reference to them?

First that I found in browser history #28457
My opinion is subjective, but I think that this question can be mentioned for discussion with Core Team

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-9064 has been created to process this Pull Request

[dmitriyprime]

✔️ QA passed

[m2-assistant]

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.