[GraphQL] Paypal PayFlowPro store the payment details in myaccount for future #28821

Usik2203 · 2020-06-21T20:16:56Z

Description (*)

This PR provide ability to store my Paypal (PayFlowPro) payment method details in myaccount.

Related Pull Requests

https://github.com/magento/partners-magento2-infrastructure/pull/15

Useful links:
PayFloPro Documentation
PayFloPro GraphQl Documentation
How to create test PayPal accout for testing
List of credit carts

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. You should configure Payflowpro payment method.
2. Login as Customer
3. Add product to cart and go to payment step on checkout

4. Get customer quote id by running request

{
  customerCart {
    id
    items {
      id
      product {
        name
        sku
      }
      quantity
    }
  }
}

5. Set payment method for quote

  setPaymentMethodOnCart(
    input: {
    cart_id: "zqYVjMInihkXlKVJAfgbY2yQsVdc6qLR"
    payment_method: {
      code: "payflowpro"
      payflowpro: {
           is_active_payment_token_enabler: true
          cc_details: {
           cc_type: "VI"
           cc_exp_year: 2025
           cc_exp_month: 7
           cc_last_4: 1881
        }
      }
    }
  })
  {
    cart {
      id
      selected_payment_method {
        code
        purchase_order_number
      }
  }
  }
}

6. Get secure tokens

mutation {
  createPayflowProToken(
    input: {
      cart_id: "zqYVjMInihkXlKVJAfgbY2yQsVdc6qLR"
      urls: {
        return_url: "paypal/transparent/return"
        cancel_url: "paypal/transparent/cancel"
        error_url: "paypal/transparent/error"
      }
      
    }
  ) {
    response_message
    result
    result_code
    secure_token
    secure_token_id
  }
}

7. Run handlePayflowProResponse mutation
handlePayflowProResponse Documentation
You can get paypal_payload parameter from

mutation {
  handlePayflowProResponse(
    input: {
      cart_id: "zqYVjMInihkXlKVJAfgbY2yQsVdc6qLR"
      paypal_payload: "BILLTOCITY=dcdcd&AMT=0.00&BILLTOEMAIL=o.usik%40atwix.com&BILLTOSTREET=dcdc%40gmail.com&CC_TYPE=VI&SHIPTOCITY=dcdcd&NAMETOSHIP=Oleh+Usik&ZIP=12345&BILLTOLASTNAME=Usik&BILLTOFIRSTNAME=Oleh&RESPMSG=Verified&PROCCVV2=M&STATETOSHIP=AK&NAME=Oleh+Usik&BILLTOZIP=12345&CVV2MATCH=Y&PNREF=A71AADB57BB0&ZIPTOSHIP=12345&SHIPTOCOUNTRY=US&SHIPTOSTREET=dcdc%40gmail.com&CITY=dcdcd&HOSTCODE=A&LASTNAME=Usik&STATE=AK&SECURETOKEN=7dTXlaJR3nkeJ356hXrIbMAhx&CITYTOSHIP=dcdcd&COUNTRYTOSHIP=US&AVSDATA=XXN&ACCT=5100&AUTHCODE=333PNI&FIRSTNAME=Oleh&RESULT=0&IAVS=X&POSTFPSMSG=No+Rules+Triggered&BILLTOSTATE=AK&BILLTOCOUNTRY=US&EXPDATE=0725&EMAIL=o.usik%40atwix.com&CARDTYPE=1&PREFPSMSG=No+Rules+Triggered&SHIPTOZIP=12345&PROCAVS=U&COUNTRY=US&AVSZIP=X&ADDRESS=dcdc%40gmail.com&BILLTONAME=Oleh+Usik&ADDRESSTOSHIP=dcdc%40gmail.com&AVSADDR=X&SECURETOKENID=hOidzKMVR3KMFeTS6UpLJVMacQ5GMuhk&SHIPTOSTATE=AK&TRANSTIME=2020-06-21+11%3A36%3A53"
      
    }
  ){
    cart {
      selected_payment_method {
        code
      }
    }
  }
}

8. Place order

 
mutation {
  placeOrder(
    input: {
      cart_id: "zqYVjMInihkXlKVJAfgbY2yQsVdc6qLR"
    }
  ) {
    order {
      order_number
    }
  }
}

Result

m2-assistant · 2020-06-21T20:16:58Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

Usik2203 · 2020-06-22T09:43:54Z

@magento run all tests

Usik2203 · 2020-06-22T12:51:41Z

@magento run Integration Tests

Usik2203 · 2020-06-22T20:21:11Z

@magento run all tests

Usik2203 · 2020-06-23T07:02:24Z

@magento run all tests

Usik2203 · 2020-06-23T10:31:16Z

@magento run all tests

Usik2203 · 2020-06-23T12:34:32Z

@magento run Unit Tests , Functional Tests CE

rogyar · 2020-06-23T16:14:02Z

app/code/Magento/PaypalGraphQl/Observer/PayflowProSetCcData.php

+            $paymentModel->setData(self::IS_ACTIVE_PAYMENT_TOKEN_ENABLER, false);
+        }
+
+        foreach ($additionalData['cc_details'] as $ccKey => $ccValue) {


Could you provide more info, please, on what exact data will be saved to the payment model?

I'm asking since we need to make sure that no unnecessary data is being written to the database accidentally. It might be tricky from the security perspective

Hi @rogyar
I have changed foreach to

$paymentModel->setCcType($ccData['cc_type']); $paymentModel->setCcExpYear($ccData['cc_exp_year']); $paymentModel->setCcExpMonth($ccData['cc_exp_month']); $paymentModel->setCcLast4($ccData['cc_last_4']);

Is it right ?
Thank you for advice !

avattam06 · 2020-07-31T21:52:50Z

@magento run Functional Tests B2B

avattam06 · 2020-08-03T16:36:49Z

Does the vault still have the tokenDetails even after the vault_enabler is set to 0
(or disabled)?

Yes, Data is stored but not visible. @ dthampy

…unt for future #28821

prabhuram93 · 2020-08-13T04:08:19Z

@avattam06 The issue changes are in, but the Pr status is not merged yet because your last 2.4 merge commit db47d6c didn't get in. We should bundle it with next Pr to have this merged. cc: @Usik2203

avattam06 · 2020-08-13T16:48:21Z

@avattam06 The issue changes are in, but the Pr status is not merged yet because your last 2.4 merge commit db47d6c didn't get in. We should bundle it with next Pr to have this merged. cc: @Usik2203

Okay, Thanks, @prabhuram93.

Usik2203 · 2020-08-19T14:25:39Z

Hi @prabhuram93 @avattam06
Could I kindly ask you about the fate of this PR .
Will this PR be merged ?
Thanks !

avattam06 · 2020-08-19T14:28:46Z

Hi @prabhuram93 @avattam06
Could I kindly ask you about the fate of this PR .
Will this PR be merged ?
Thanks !

Hi @Usik2203 , We are waiting on bundling it with the next PR which is ready to be merged. It will be merged soon.

Thanks!

m2-assistant · 2020-08-27T20:40:19Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Usik2203 added 2 commits June 10, 2020 12:31

add data to schema

d29468d

add cc data

e798f75

ghost added the Progress: pending review label Jun 21, 2020

magento-engcom-team added Component: PaypalGraphQl Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 21, 2020

Add some checks

934db87

fix static issues

aef0f96

rogyar self-assigned this Jun 23, 2020

Fix static issue

dee5009

rogyar reviewed Jun 23, 2020

View reviewed changes

nrkapoor assigned dthampy, avattam06 and prabhuram93 Jun 24, 2020

nrkapoor added this to the 2.4.1 milestone Jun 24, 2020

nrkapoor added the Project: GraphQL label Jun 24, 2020

nrkapoor unassigned dthampy, avattam06 and prabhuram93 Jun 24, 2020

nrkapoor requested review from avattam06 and prabhuram93 June 24, 2020 02:06

avattam06 changed the title ~~[GraphQL] PayFloPro store the payment details in myaccount for future~~ [GraphQL] Paypal PayFlowPro store the payment details in myaccount for future Jul 31, 2020

prabhuram93 self-requested a review July 31, 2020 21:41

prabhuram93 approved these changes Jul 31, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: accept labels Jul 31, 2020

avattam06 approved these changes Jul 31, 2020

View reviewed changes

ghost assigned avattam06 Jul 31, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 31, 2020

ghost added Progress: accept and removed Progress: testing in progress labels Jul 31, 2020

avattam06 added 2 commits August 3, 2020 11:39

Removed duplicated assertion

05e9e4e

Merge branch '2.4-develop' into paypalflowpro-graphql

db47d6c

This was referenced Aug 7, 2020

Implement the schema for PayPal PayFloPro #28520

Closed

Implement the schema for PayPal PayFloPro #28558

Closed

magento-engcom-team pushed a commit that referenced this pull request Aug 7, 2020

ENGCOM-7916: [GraphQL] PayFlowPro store the payment details in myacco…

6f4d800

…unt for future #28821

magento-engcom-team merged commit ccc4e7e into magento:2.4-develop Aug 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GraphQL] Paypal PayFlowPro store the payment details in myaccount for future #28821

[GraphQL] Paypal PayFlowPro store the payment details in myaccount for future #28821

Usik2203 commented Jun 21, 2020 •

edited by avattam06

Loading

m2-assistant bot commented Jun 21, 2020

Usik2203 commented Jun 22, 2020

Usik2203 commented Jun 22, 2020

Usik2203 commented Jun 22, 2020

Usik2203 commented Jun 23, 2020

Usik2203 commented Jun 23, 2020

Usik2203 commented Jun 23, 2020

rogyar Jun 23, 2020

rogyar Jun 23, 2020

Usik2203 Jun 24, 2020 •

edited

Loading

avattam06 commented Jul 31, 2020

avattam06 commented Aug 3, 2020

prabhuram93 commented Aug 13, 2020

avattam06 commented Aug 13, 2020

Usik2203 commented Aug 19, 2020

avattam06 commented Aug 19, 2020

m2-assistant bot commented Aug 27, 2020

[GraphQL] Paypal PayFlowPro store the payment details in myaccount for future #28821

[GraphQL] Paypal PayFlowPro store the payment details in myaccount for future #28821

Conversation

Usik2203 commented Jun 21, 2020 • edited by avattam06 Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

m2-assistant bot commented Jun 21, 2020

Usik2203 commented Jun 22, 2020

Usik2203 commented Jun 22, 2020

Usik2203 commented Jun 22, 2020

Usik2203 commented Jun 23, 2020

Usik2203 commented Jun 23, 2020

Usik2203 commented Jun 23, 2020

rogyar Jun 23, 2020

Choose a reason for hiding this comment

rogyar Jun 23, 2020

Choose a reason for hiding this comment

Usik2203 Jun 24, 2020 • edited Loading

Choose a reason for hiding this comment

avattam06 commented Jul 31, 2020

avattam06 commented Aug 3, 2020

prabhuram93 commented Aug 13, 2020

avattam06 commented Aug 13, 2020

Usik2203 commented Aug 19, 2020

avattam06 commented Aug 19, 2020

m2-assistant bot commented Aug 27, 2020

Usik2203 commented Jun 21, 2020 •

edited by avattam06

Loading

Usik2203 Jun 24, 2020 •

edited

Loading