Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQL] Paypal PayFlowPro store the payment details in myaccount for future #28821
[GraphQL] Paypal PayFlowPro store the payment details in myaccount for future #28821
Changes from 24 commits
d29468d
e798f75
934db87
aef0f96
dee5009
2e6e63e
f714e12
009a3ba
c28747d
6596e65
d6a2fb7
57b733f
1422df6
dbb3427
6b3da47
1baeb21
7bd8e06
afaede9
986d5b1
6925546
d723f24
065c780
d47baa8
a37e651
fd8e270
af7ece4
47d7be2
3c9406d
e4d71d1
05e9e4e
db47d6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keharper @joni-jones I added a store config field for vault. Let me know if the name/description needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prabhuram93, my understanding that for
StoreConfig
values, we follow the same semantic as inconfig.xml
. For Payflow Pro it will bepayment_payflowpro_cc_vault_active
.cc @paliarush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joni-jones We were doing that until we implemented aliasing. We can have custom field names that are not tied to config.xml. But if you feel
payment_payflowpro_cc_vault_active
is more relevant I can update accordingly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the description to Payflow Pro to match PayPal's branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have aliases now, let's use whatever makes the most sense from the API client perspective. We also need to make sure to have proper namespaces to prevent conflicts in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paliarush
payment_payflowpro_cc_vault_active
has better namespacing. @joni-jones I am gonna go with that.