Reorganize Media Gallery stores configuration UI #29433

konarshankar07 · 2020-08-07T05:42:18Z

Description (*)

This PR will reversed the media gallery configuration

Fixed Issues (if relevant)

Fixes Reorganize Media Gallery stores configuration UI adobe-stock-integration#1738 : Reorganize Media Gallery stores configuration

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-08-07T05:42:20Z

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

konarshankar07 · 2020-08-07T05:42:41Z

@magento run all tests

konarshankar07 · 2020-08-07T05:45:21Z

app/code/Magento/MediaGalleryUi/etc/adminhtml/menu.xml

+             sortOrder="15"
+             parent="Magento_Backend::content"
+             resource="Magento_Cms::media_gallery"
+             dependsOnConfig="system/media_gallery/enabled"/>


@sivaschenko ...
Do we need to display this menu if old media gallery is enabled?
Thanks

Only Sores configuration representation should be changed in scope of the issue

But I didn't understood if Enable Old Media Gallery is set to Yes then the menu will be visible

konarshankar07 · 2020-08-07T07:53:38Z

@magento run Integration Tests

konarshankar07 · 2020-08-07T08:20:52Z

@magento run Functional Tests CE

konarshankar07 · 2020-08-07T11:33:19Z

@magento run Functional Tests CE

sivaschenko

Thanks for the PRs @konarshankar07 ! Please see my comments

sivaschenko · 2020-08-07T13:19:08Z

app/code/Magento/MediaGalleryUi/etc/adminhtml/system.xml

                <field id="enabled" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0">
-                    <label>Enabled</label>
+                    <label>Enable Old Media Gallery</label>
                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>


@konarshankar07 can you please keep the existing value for enabled media gallery and just change the option values for Stores Configuration.

sivaschenko · 2020-08-07T13:19:41Z

app/code/Magento/MediaGalleryUi/etc/adminhtml/menu.xml

+             sortOrder="15"
+             parent="Magento_Backend::content"
+             resource="Magento_Cms::media_gallery"
+             dependsOnConfig="system/media_gallery/enabled"/>


Only Sores configuration representation should be changed in scope of the issue

This reverts commit 3633542.

This reverts commit 8b592ee.

This reverts commit 651bd69.

konarshankar07 · 2020-08-14T08:29:30Z

@magento run all tests

magento-engcom-team · 2020-08-14T13:53:46Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8014 has been created to process this Pull Request

engcom-Lima · 2020-08-18T10:20:41Z

✔️ QA Passed

Section label is changed from Enhanced Media Gallery to Media Gallery
Select label is changed from Enable to Enable Old Media Gallery
Select option values is reversed

m2-assistant · 2020-08-19T10:43:16Z

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Media Gallery configuration are reversed

3633542

ghost added the Progress: pending review label Aug 7, 2020

magento-engcom-team added Component: MediaGalleryUi Component: MediaGallerySynchronization Component: MediaGalleryIntegration Component: MediaGalleryCatalogIntegration Release Line: 2.4 labels Aug 7, 2020

konarshankar07 commented Aug 7, 2020

View reviewed changes

fixed MFTF test

651bd69

Enabled old media gallery by default

8b592ee

konarshankar07 mentioned this pull request Aug 7, 2020

#1738 :- Reorganize Media Gallery stores configuration magento/adobe-stock-integration#1739

Closed

sivaschenko requested changes Aug 7, 2020

View reviewed changes

ghost assigned sivaschenko Aug 7, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 7, 2020

sivaschenko added the Project: ASI label Aug 9, 2020

sivaschenko changed the title ~~{ASI} :- #1738 :- Reorganize Media Gallery stores configuration~~ Reorganize Media Gallery stores configuration UI Aug 12, 2020

sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 12, 2020

konarshankar07 added 4 commits August 14, 2020 13:42

Revert "Media Gallery configuration are reversed"

3fc2303

This reverts commit 3633542.

Revert "Enabled old media gallery by default"

e76cb95

This reverts commit 8b592ee.

Revert "fixed MFTF test"

1fe9c22

This reverts commit 651bd69.

Reversed Store configuration

de6d2a7

sivaschenko approved these changes Aug 14, 2020

View reviewed changes

sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 14, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 14, 2020

magento-engcom-team removed Component: MediaGalleryCatalogIntegration Component: MediaGalleryIntegration Component: MediaGallerySynchronization labels Aug 14, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 18, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 18, 2020

ghost added Progress: accept and removed Progress: extended testing labels Aug 18, 2020

magento-engcom-team mentioned this pull request Aug 19, 2020

Where the relevant information about the template  #1738

Closed

magento-engcom-team pushed a commit that referenced this pull request Aug 19, 2020

ENGCOM-8014: Reorganize Media Gallery stores configuration UI #29433

e95d82d

magento-engcom-team merged commit cef738b into magento:2.4-develop Aug 19, 2020

sidolov added this to the 2.4.2 milestone Aug 20, 2020

sivaschenko mentioned this pull request Sep 23, 2020

Updated media gallery configuration information magento/merchdocs#760

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganize Media Gallery stores configuration UI #29433

Reorganize Media Gallery stores configuration UI #29433

konarshankar07 commented Aug 7, 2020 •

edited by sivaschenko

Loading

m2-assistant bot commented Aug 7, 2020

konarshankar07 commented Aug 7, 2020

konarshankar07 Aug 7, 2020 •

edited

Loading

sivaschenko Aug 7, 2020

konarshankar07 Aug 7, 2020

konarshankar07 commented Aug 7, 2020

konarshankar07 commented Aug 7, 2020

konarshankar07 commented Aug 7, 2020

sivaschenko left a comment

sivaschenko Aug 7, 2020

sivaschenko Aug 7, 2020

konarshankar07 commented Aug 14, 2020

magento-engcom-team commented Aug 14, 2020

engcom-Lima commented Aug 18, 2020 •

edited

Loading

m2-assistant bot commented Aug 19, 2020

Reorganize Media Gallery stores configuration UI #29433

Reorganize Media Gallery stores configuration UI #29433

Conversation

konarshankar07 commented Aug 7, 2020 • edited by sivaschenko Loading

Description (*)

Fixed Issues (if relevant)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Aug 7, 2020

konarshankar07 commented Aug 7, 2020

konarshankar07 Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

sivaschenko Aug 7, 2020

Choose a reason for hiding this comment

konarshankar07 Aug 7, 2020

Choose a reason for hiding this comment

konarshankar07 commented Aug 7, 2020

konarshankar07 commented Aug 7, 2020

konarshankar07 commented Aug 7, 2020

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko Aug 7, 2020

Choose a reason for hiding this comment

sivaschenko Aug 7, 2020

Choose a reason for hiding this comment

konarshankar07 commented Aug 14, 2020

magento-engcom-team commented Aug 14, 2020

engcom-Lima commented Aug 18, 2020 • edited Loading

m2-assistant bot commented Aug 19, 2020

konarshankar07 commented Aug 7, 2020 •

edited by sivaschenko

Loading

konarshankar07 Aug 7, 2020 •

edited

Loading

engcom-Lima commented Aug 18, 2020 •

edited

Loading