Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where the relevant information about the template <!--ko--> #1738

Closed
LifeAsBook opened this issue Aug 25, 2015 · 3 comments
Closed

Where the relevant information about the template <!--ko--> #1738

LifeAsBook opened this issue Aug 25, 2015 · 3 comments
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@LifeAsBook
Copy link

No description provided.

@vpelipenko vpelipenko added the CS label Aug 25, 2015
@vkorotun vkorotun self-assigned this Sep 1, 2015
@guz-anton
Copy link
Contributor

<!-- ko -->

is a part of Knockout templates syntax. Mostly such code used in Ui Components in client-side templates. You could find in Magento box several .html files with it.

This funny comments used as alternative for node binding: <div data-bind="..." />, where presence of real DOM node not so suitable.

<!-- ko <some_binding>: <object_of_options>, <another_binding>: <another_options> -->
<!-- /ko -->

Syntax consist with little auxiliary part, <some_binding> name and <object_of_options> in JSON format.

List of Magento bindings could be found on Magento2 Github.

More about Knockout templates and bindings: http://knockoutjs.com/documentation/binding-syntax.html

@LifeAsBook
Copy link
Author

thank you！ i have found

okorshenko pushed a commit that referenced this issue Nov 21, 2017
Merge pull request #1738 from magento-engcom/2.2-develop-prs
513e9f5 
Public Pull Requests

#12003 #11691: Wrong return type for getAttributeText($attributeCode) by @p-bystritsky
#12308 12261: Order confirmation email contains non functioning links #12261 by @RomaKis
#11787 Fix #10438: Potential error on order edit page when address has extension attributes by @joni-jones

Fixed Public Issues

#11691 Wrong return type for getAttributeText($attributeCode)
#12261 Order confirmation email contains non functioning links
#10438 Potential error on order edit page when address has extension attributes
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @LifeAsBook. Thank you for your report.
The issue has been fixed in #29433 by @konarshankar07 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@guz-anton @vpelipenko @vkorotun @LifeAsBook @magento-engcom-team