fix #30094 function call on array

[Morgy93]

Description (*)

Fixes #30094:
Call to a member function getId() on array in module-sales/view/adminhtml/templates/order/totals/tax.phtml:62

Fixed Issues (if relevant)

1. Fixes Call to a member function getId() on array in module-sales/view/adminhtml/templates/order/totals/tax.phtml:62 #30094

Manual testing scenarios (*)

1. Set config tax/sales_display/full_summary to 1
2. Open any invoice (e.g. /admin/sales/invoice/view/invoice_id/1/)

Questions or comments

Issue is introduced here 70ede03
Using the same rather "workaround" as below for $infoId: https://github.com/magento/magento2/blob/2.4.1/app/code/Magento/Sales/view/adminhtml/templates/order/totals/tax.phtml#L91

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] fix #30094 function call on array #33638: fix Call to a member function getId() on array in module-sales/view/adminhtml/templates/order/totals/tax.phtml:62 #30094 function call on array

Resolved issues:

1. resolves [Issue] fix #30094 function call on array #33639: fix Call to a member function getId() on array in module-sales/view/adminhtml/templates/order/totals/tax.phtml:62 #30094 function call on array

[Morgy93]

@magento run all tests

[Morgy93]

@magento run 3

[Morgy93]

@magento run Functional Tests EE

[rogyar]

Hi @Morgy93. Thank you for providing the fix. Could you, please, check my suggestions below?

Thanks!

[Morgy93]

@rogyar Thanks for the review! I just replied to your comment.

[Morgy93]

@magento run Functional Tests EE
@magento run Functional Tests B2B

Any clue why those two fail? I doubt it's because this marginal PR change, but who knows..

[Morgy93]

See.... without any changes the Functional Tests EE succeeded. After the third try..
Now onto the last one:
@magento run Functional Tests B2B

[Morgy93]

@magento run Functional Tests B2B

[rogyar]

Hi @Morgy93. According to the definition of done all the changes must be covered with automated tests. Could I ask you to cover this fix with an MFTF test, please?

Thank you

[Morgy93]

@rogyar There's already a MFTF test for that page:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Sales/Test/Mftf/Section/AdminOrderInvoiceViewSection.xml

Correct me if I'm wrong, but it doesn't seem to need an update,

[rogyar]

Hi @Morgy93. We don't have a test that reproduces the steps described in the original issue and checks that we don't have the error anymore. So, we need to add a new test.

Basically, the new test will do the following

• Go to Store -> Configuration -> Sales -> Tax -> Orders, Invoices, Credit Memos Display Settings -> Display Full Tax Summary and change to YES
• Go to Sales -> Orders -> Open Order -> Invoice Tab -> Open Invoice -> Make sure that there's no "Call to a member function" is not present in the page source.

Hope it will help

[Morgy93]

@magento create issue

Actually there's an issue already: #30094 (comment)

It just got closed as "non-reproducible".
For the history and other contributors it would probably be better to use that one instead.

[hostep]

Well, what do you know, Magento just released a similar fix in MC-42332: part 1, part 2, it's great to see how the community maintainers and the internal Magento/Adobe core team are communicating with each other.

[mrtuvn]

so basically we have the fixes landed to 2.4-develop right!? So wild. Never imagine another fix come from another places

[mrtuvn]

So this fix seem redundant! But thanks you for your working efforts @Morgy93 at this

[ihor-sviziev]

Hi @Morgy93,
Looks like the issue was fixed in the 2.4-develop branch in d648bdc and 3ae814c. Could you confirm that?

[Morgy93]

This is ridiculous!

We're waiting for almost a year to have this issue fixed, provided MULTIPLE valid fixes / PR and it involved many official staff who all refused to apply them.
Now we presented a 100% reproducible way and SUDDENLY the official staff fixed the error on its own - silently.
Without a SINGLE WORD to the community.

Big thanks to every single one of you who contributed here! Closed~

[m2-assistant]

Hi @Morgy93, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[hostep]

@sidolov: maybe you can communicate with Adobe's internal Magento developers to first check github for open PR's when they are presented an issue they have to resolve. That could save some frustration from the community and might speed things up for accepting/merging PR's here.

/cc @o-dubovyk

[sidolov]

@Morgy93 I apologize for the situation that happened here! Usually, we have a copy of every issue in our backlog for internal teams and developers have to check for open public pull requests first. In this case, the same issue was reported and fixed by the internal developer, that's why identical fixes came from different sources. I'm pretty sure, anyone didn't mean to copy your fix and deliver it as a part of the core code. We will try to adjust the process to avoid such cases!