-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of EAV cache type #31264
Fix usage of EAV cache type #31264
Conversation
Hi @ilnytskyi. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 I don't see any critical issues there.
Let's wait for Static Tests to finish, but the only issue is code style to adjust.
@magento run all tests |
I think that in |
5f17403
to
fc04ddb
Compare
fc04ddb
to
66d2586
Compare
@magento run all tests |
I decided to open PR after I saw this change. But now i see it's a bit bigger problem. 4b66b00#diff-b3fae67f1de2de925eb945c0dac8213f1f6f817053039c4d15eb698a338a3ac3 @vzabaznov could you take a look at this issue and help us figure out what to do? I our project we use different cache backends for different cache types. Mainly to reduce data transfer from redis, and isolate containers in ASG and with 2.4.1 magento we faced the issue, that in RemoteSynchronized cache not all EAV keys were stored in containers. The first issue was the necessity to use a separate frontend with the name Probably the issue was not noticed since devs don't usually use this approach to point some caches to different storages, or do not debug if the keys actually come from proper storage. This is serious issue because these docs pages do not really represent what actually going inside the app. |
@maghamed could you explain some differences between As a dev I do not see point to define EAV cache type in XML https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Eav/etc/cache.xml and then use different classes that implement different interfaces to actually work with the cache storage. |
@magento run WebAPI Tests |
1 similar comment
@magento run WebAPI Tests |
Sorry, @engcom-Hotel - I'm no longer Maintainer. |
@magento run all tests |
@magento run all tests |
@magento run Functional Tests B2B |
The Functional B2B test failures are different in recent 2 successive builds with a known issue. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress. Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31264/61d013f3b977f3c8f51d8ebb9bc04fcc/Functional/allure-report-b2b/index.html#categories/a3bd7bb7965715d4b4c20d3e9cf75c2a/dd6bdc519ebcf74d/ |
830a2ad
into
magento:2.4-develop
Description (*)
This PR fixes usage of EAV cache type in some places
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
configured_eav_cache
virtual typeUPD: looks like it's bigger problem I see many other classes do not use
\Magento\Eav\Model\Cache\Type
and they can't be fixed due toMagento\Framework\App\CacheInterface
andMagento\Framework\Cache\FrontendInterface
incompatibilities.It should be figured out and fixed in different PR/issue.
\Magento\Catalog\Plugin\Model\ResourceModel\Config
checks if EAV cache enabled but store data in default cache type. This PR fixes missed configurationQuestions or comments
Contribution checklist (*)
Resolved issues: