Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting to support PHP 8 #31269

Closed
wants to merge 2 commits into from
Closed

Starting to support PHP 8 #31269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23b8536
Fixes #31177 #31176 #31175 #31174 #31173 #31082 In order to help with…
jamescowie Dec 12, 2020
139a59b
Merge branch '2.4-develop' into feature/PHP8-Support
Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"sort-packages": true
},
"require": {
"php": "~7.3.0||~7.4.0",
"php": "~7.3.0||~8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"php": "~7.3.0||~8",
"php": "^7.3.0||~8",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe is should be set to "php": "~7.4.0||~8.0.0" however this should be changed in scope of #31081

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you are not planning to complete all scope of #31081 in the pull request, please do not change the PHP versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not change the dependency - we can't update composer packages.

Copy link
Contributor

@ihor-sviziev ihor-sviziev Jan 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I suggest changing to this:

Suggested change
"php": "~7.3.0||~8",
"php": "^7.3.0||~8.0.0",

So it will still be compatible with PHP 7.3, 7.4, and 8.0

@jamescowie, could you do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-sviziev we can't update composer packages until all dependencies are updated. I think it makes sense to update the version together with (or after) the codebase

I'd stick to "~7.3.0||~7.4.0||~8.0.0" just in case 7.5 appears unexpectedly :D

"ext-bcmath": "*",
"ext-ctype": "*",
"ext-curl": "*",
Expand All @@ -37,11 +37,10 @@
"guzzlehttp/guzzle": "^6.3.3",
"laminas/laminas-captcha": "^2.7.1",
"laminas/laminas-code": "~3.4.1",
"laminas/laminas-config": "^2.6.0",
"laminas/laminas-console": "^2.6.0",
"laminas/laminas-crypt": "^2.6.0",
"laminas/laminas-db": "^2.8.2",
"laminas/laminas-dependency-plugin": "^1.0",
"laminas/laminas-dependency-plugin": "^2.1.0",
"laminas/laminas-di": "^2.6.1",
"laminas/laminas-eventmanager": "^3.0.0",
"laminas/laminas-feed": "^2.9.0",
Expand Down Expand Up @@ -87,15 +86,15 @@
},
"require-dev": {
"allure-framework/allure-phpunit": "~1.2.0",
"dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.0",
"friendsofphp/php-cs-fixer": "~2.16.0",
"lusitanian/oauth": "~0.8.10",
"magento/magento-coding-standard": "*",
"magento/magento2-functional-testing-framework": "^3.0",
"pdepend/pdepend": "~2.7.1",
"phpcompatibility/php-compatibility": "^9.3",
"phpmd/phpmd": "^2.8.0",
"phpstan/phpstan": ">=0.12.3 <=0.12.23",
"phpstan/phpstan": ">=0.12.3 <=0.12.54",
"phpunit/phpunit": "^9",
"sebastian/phpcpd": "~5.0.0",
"squizlabs/php_codesniffer": "~3.5.4"
Expand Down
Loading