-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting to support PHP 8 #31269
Starting to support PHP 8 #31269
Conversation
…#31173 magento#31082 In order to help with PHP8 support
Hi @jamescowie. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@@ -11,7 +11,7 @@ | |||
"sort-packages": true | |||
}, | |||
"require": { | |||
"php": "~7.3.0||~7.4.0", | |||
"php": "~7.3.0||~8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"php": "~7.3.0||~8", | |
"php": "^7.3.0||~8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request @jamescowie !
I believe it will be much easier to work on one task at a time. Can you please try to address a single issue with a single pull request?
@@ -11,7 +11,7 @@ | |||
"sort-packages": true | |||
}, | |||
"require": { | |||
"php": "~7.3.0||~7.4.0", | |||
"php": "~7.3.0||~8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe is should be set to "php": "~7.4.0||~8.0.0"
however this should be changed in scope of #31081
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you are not planning to complete all scope of #31081 in the pull request, please do not change the PHP versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do not change the dependency - we can't update composer packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I suggest changing to this:
"php": "~7.3.0||~8", | |
"php": "^7.3.0||~8.0.0", |
So it will still be compatible with PHP 7.3, 7.4, and 8.0
@jamescowie, could you do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ihor-sviziev we can't update composer packages until all dependencies are updated. I think it makes sense to update the version together with (or after) the codebase
I'd stick to "~7.3.0||~7.4.0||~8.0.0" just in case 7.5 appears unexpectedly :D
@magento run all tests |
@jamescowie would you like to continue working on this contribution? |
Closing due to inactivity |
Hi @jamescowie, thank you for your contribution! |
Starting to add support for PHP 8 based on the libs required.
Fixes #31177
Fixes #31176
Fixes #31175
Fixes #31174
Fixes #31173
Fixes #31082