Starting to support PHP 8

[jamescowie]

Starting to add support for PHP 8 based on the libs required.

Fixes #31177
Fixes #31176
Fixes #31175
Fixes #31174
Fixes #31173
Fixes #31082

[m2-assistant]

Hi @jamescowie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Suggested change

	"php": "~7.3.0||~8",
	"php": "^7.3.0||~8",

[sivaschenko]

Thanks for the pull request @jamescowie !

I believe it will be much easier to work on one task at a time. Can you please try to address a single issue with a single pull request?

[sivaschenko]

I believe is should be set to "php": "~7.4.0||~8.0.0" however this should be changed in scope of #31081

[sivaschenko]

In case you are not planning to complete all scope of #31081 in the pull request, please do not change the PHP versions

[ihor-sviziev]

If we do not change the dependency - we can't update composer packages.

[ihor-sviziev]

For now, I suggest changing to this:

Suggested change

	"php": "~7.3.0||~8",
	"php": "^7.3.0||~8.0.0",

So it will still be compatible with PHP 7.3, 7.4, and 8.0

@jamescowie, could you do that?

[sivaschenko]

@ihor-sviziev we can't update composer packages until all dependencies are updated. I think it makes sense to update the version together with (or after) the codebase

I'd stick to "~7.3.0||~7.4.0||~8.0.0" just in case 7.5 appears unexpectedly :D

[sivaschenko]

@magento run all tests

[sivaschenko]

@jamescowie would you like to continue working on this contribution?

[sivaschenko]

Closing due to inactivity

[m2-assistant]

Hi @jamescowie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.