Update league dependencies to PHP 8 compatible versions

[sivaschenko]

In scope of the user story MC-41382 we need to the update league/flysystem, league/flysystem-aws-s3-v3 and league/flysystem-cached-adapter dependency versions from "^{1.0" to "}2.0"

 

In scope of this spice we need to estimate the effort required to provide that upgrade.

 

[m2-assistant]

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sergeynezbritskiy]

@magento I am working on this

[sergeynezbritskiy]

Hi @sivaschenko I checked the ability to upgrade league packages
Here is what I've found:

1. package league/flysystem-cached-adapter has the highest tag 1.1.0 at the moment, and this the version we use right now, so nothing to update here
2. at the same time this package has a constraint on league/flysystem ~1.0, which makes impossible to update this package to 2.0
3. current version of league/flysystem is 1.1.3 which already does support php8, so no need to update this package itself in terms of compatibility with php8
4. Package league/flysystem-aws-s3-v3 needs to be updates but versions 2.0.0 and higher require league/flysystem ^2.0.0 and this conflicts with our current version of flysystem

Currently it looks like we just need package league/flysystem-cached-adapter to support league/flysystem:^2.0. So should I just wait while the new version of league/flysystem-cached-adapter will be released ?

I'm a bit confused how to deal with it. please suggest

Thanks in advance

[sergeynezbritskiy]

FYI: created internal issue for league/flysystem-cached-adapter to track the progress https://github.com/thephpleague/flysystem-cached-adapter/issues/41
cc: @sivaschenko

[sivaschenko]

Thanks for the detailed investigation @sergeynezbritskiy ! Yes, we have to wait until league/flysystem-cached-adapter version compatible with league/flysystem:^2.0 will be released to update all 3 packages.

[magento-engcom-team]

Hi @sivaschenko, @sergeynezbritskiy, @engcom-Kilo.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39646 was closed as Complete.

The fix will be available with the upcoming 2.4.3 release.

[magento-engcom-team]

Hi @sivaschenko, @sergeynezbritskiy, @engcom-Kilo.

Thank you for your report and collaboration!

The related internal Jira ticket MC-41385 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.