Upgrade flysystem to version ^2.0 #32534

engcom-Kilo · 2021-03-17T17:46:45Z

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/530

Fixed Issues (if relevant)

Resolves #31177

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-03-17T17:46:47Z

Hi @engcom-Kilo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Kilo · 2021-03-18T12:39:10Z

@magento run all tests

# Conflicts: # composer.lock

sivaschenko

Thanks for the pull request! Please see my comments

app/code/Magento/AwsS3/Driver/AwsS3.php

app/code/Magento/AwsS3/Model/Cached/CachedAdapter.php

sivaschenko · 2021-03-19T13:29:43Z

app/code/Magento/AwsS3/Model/Cached/CachedAdapter.php

+    /**
+     * Get file metadata.
+     *
+     * @deplacated There is no getMetadata() method in FilesystemAdapter anymore.


Do we need to introduce this deplacated method?

There are several clients for this method:
Magento\Eav\Model\Attribute\Data\Image, Magento\MediaGallerySynchronization\Model\CreateAssetFromFile, Magento\Framework\File\Mime.

The comment and @deplacated annotation should be removed.

Is implementing League\Flysystem\FilesystemAdapter necessary?

sivaschenko · 2021-03-19T13:31:09Z

app/code/Magento/RemoteStorage/Driver/Cache/CacheInterface.php

+/**
+ * Remote storage cache interface.
+ */
+interface CacheInterface extends FilesystemReader


I wouldn't introduce extension points (interfaces) if that is not necessary

Moved Reader interface methods to Cache interface. Removed inheritance

app/code/Magento/RemoteStorage/Model/GetPathInfo.php

# Conflicts: # composer.lock

engcom-Kilo · 2021-03-22T17:27:37Z

@magento run all tests

… into Flysystem

sivaschenko · 2021-04-06T12:03:23Z

app/code/Magento/RemoteStorage/composer.json

@@ -3,7 +3,8 @@
    "description": "N/A",
    "require": {
        "php": "~7.3.0||~7.4.0",
-        "magento/framework": "*"
+        "magento/framework": "*",
+        "predis/predis": "*"


Suggested change

"predis/predis": "*"

"predis/predis": "^1.1"

sivaschenko · 2021-04-06T12:43:46Z

app/code/Magento/RemoteStorage/composer.json

@@ -14,8 +15,7 @@
        "magento/module-media-storage": "*",
        "magento/module-import-export": "*",
        "magento/module-catalog-import-export": "*",
-        "magento/module-downloadable-import-export": "*",
-        "predis/predis": "*"
+        "magento/module-downloadable-import-export": "*"


Documentation should be updated as there is no need to require predis/predis package https://devdocs.magento.com/guides/v2.4/config-guide/remote-storage/config-remote-storage-caching.html

sivaschenko · 2021-04-06T12:48:40Z

app/code/Magento/RemoteStorage/Driver/Cache/CacheInterface.php

+/**
+ * Remote storage cache interface.
+ */
+interface CacheInterface


The interface should be removed. There is only one implementation and I wouldn't introduce a new extension point in the patch release

sivaschenko · 2021-04-06T13:06:08Z

app/code/Magento/AwsS3/Model/Cached/CachedAdapter.php

+    /**
+     * Get file metadata.
+     *
+     * @deplacated There is no getMetadata() method in FilesystemAdapter anymore.


The comment and @deplacated annotation should be removed.

Is implementing League\Flysystem\FilesystemAdapter necessary?

sivaschenko · 2021-04-06T13:10:35Z

app/code/Magento/RemoteStorage/Model/Storage/Handler/Predis.php

+/**
+ * Redis cache model.
+ */
+class Predis implements CacheStorageHandlerInterface


Introduced classes should be covered by integration tests

sivaschenko · 2021-04-15T10:37:09Z

Flysystem is now updated in 2.4-develop

m2-assistant · 2021-04-15T10:37:10Z

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

m2-community-project bot added the Progress: pending review label Mar 17, 2021

engcom-Kilo changed the title ~~Upgrade flysystem to version ^2.0~~ [WIP] Upgrade flysystem to version ^2.0 Mar 17, 2021

engcom-Kilo requested a review from sivaschenko March 17, 2021 17:48

engcom-Kilo force-pushed the Flysystem branch 4 times, most recently from 84dc243 to 8013bea Compare March 18, 2021 12:39

Upgrade flysystem to ver 2.

a11ab4a

engcom-Kilo force-pushed the Flysystem branch from 8013bea to a11ab4a Compare March 18, 2021 18:50

Merge remote-tracking branch 'mainline/php8-develop' into Flysystem

7fbe973

# Conflicts: # composer.lock

sivaschenko added the Project: PHP8 label Mar 19, 2021

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 19, 2021

sivaschenko linked an issue Mar 19, 2021 that may be closed by this pull request

Update laminas/laminas-captcha dependency to PHP 8 compatible version #32443

Closed

sivaschenko removed a link to an issue Mar 19, 2021

Update laminas/laminas-captcha dependency to PHP 8 compatible version #32443

Closed

sivaschenko reviewed Mar 19, 2021

View reviewed changes

m2-community-project bot assigned sivaschenko Mar 19, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Mar 19, 2021

Upgrade flysystem to ver 2.

42ed46a

engcom-Kilo force-pushed the Flysystem branch from aa11f95 to 42ed46a Compare March 19, 2021 16:26

Merge branch 'php8-develop' into Flysystem

652e020

# Conflicts: # composer.lock

engcom-Kilo force-pushed the Flysystem branch 3 times, most recently from 7a88b70 to 81fd686 Compare March 22, 2021 10:06

engcom-Kilo force-pushed the Flysystem branch from 81fd686 to 434bd5c Compare March 22, 2021 13:07

Upgrade flysystem to ver 2.

c01d49e

engcom-Kilo force-pushed the Flysystem branch from 434bd5c to c01d49e Compare March 22, 2021 17:27

engcom-Kilo changed the title ~~[WIP] Upgrade flysystem to version ^2.0~~ Upgrade flysystem to version ^2.0 Mar 23, 2021

Merge branch 'php8-develop' of github.com:magento-commerce/magento2ce…

b4bf1cf

… into Flysystem

sivaschenko requested changes Apr 6, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Apr 6, 2021

sivaschenko requested a review from shiftedreality April 6, 2021 13:13

m2-community-project bot added Progress: on hold and removed Progress: needs update labels Apr 7, 2021

sivaschenko closed this Apr 15, 2021

m2-community-project bot removed the Progress: on hold label Apr 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade flysystem to version ^2.0 #32534

Upgrade flysystem to version ^2.0 #32534

engcom-Kilo commented Mar 17, 2021 •

edited

Loading

m2-assistant bot commented Mar 17, 2021

engcom-Kilo commented Mar 18, 2021

sivaschenko left a comment

sivaschenko Mar 19, 2021

engcom-Kilo Mar 22, 2021

sivaschenko Apr 6, 2021

sivaschenko Mar 19, 2021 •

edited

Loading

engcom-Kilo Mar 19, 2021 •

edited

Loading

engcom-Kilo commented Mar 22, 2021

sivaschenko Apr 6, 2021

sivaschenko Apr 6, 2021

sivaschenko Apr 6, 2021

sivaschenko Apr 6, 2021

sivaschenko Apr 6, 2021

sivaschenko commented Apr 15, 2021

m2-assistant bot commented Apr 15, 2021

Upgrade flysystem to version ^2.0 #32534

Upgrade flysystem to version ^2.0 #32534

Conversation

engcom-Kilo commented Mar 17, 2021 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Mar 17, 2021

engcom-Kilo commented Mar 18, 2021

sivaschenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sivaschenko Mar 19, 2021 • edited Loading

Choose a reason for hiding this comment

engcom-Kilo Mar 19, 2021 • edited Loading

Choose a reason for hiding this comment

engcom-Kilo commented Mar 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sivaschenko commented Apr 15, 2021

m2-assistant bot commented Apr 15, 2021

engcom-Kilo commented Mar 17, 2021 •

edited

Loading

sivaschenko Mar 19, 2021 •

edited

Loading

engcom-Kilo Mar 19, 2021 •

edited

Loading