-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark exceptions as api #32085
Mark exceptions as api #32085
Conversation
Hi @vlmed. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vlmed thank you for the adjustments. There is one point explained to me: the @since
will be set automatically during the merge. So, please, remove it :)
df962f8
to
081ffff
Compare
@coderimus Thanks for the explanation. |
Hi @coderimus, thank you for the review.
|
@magento run all tests |
@magento run all tests |
Hi @vlmed can you recreate this PR to the Thanks! |
Hi @gabrieldagama. Done. #33103 |
Hi @vlmed, thank you for your contribution! |
Description (*)
The follwoing Exceptions marked as API:
Fixed Issues (if relevant)
Questions or comments
@coderimus
Contribution checklist (*)