-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated deprecated classes #32086
base: 2.5-develop
Are you sure you want to change the base?
Updated deprecated classes #32086
Conversation
Hi @ProkopovVitaliy. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
@magento run all tests |
Description (*)
In tis PR i did next.
If interface not used i deleted him.
app/code/Magento/CustomerGraphQl/Api/ValidateCustomerDataInterface
moved toMagento\CustomerGraphQl\Model\Customer
folder. I moved tho the Model namespace those interfaces according to the technical vision https://devdocs.magento.com/guides/v2.4/coding-standards/technical-guidelines.html#64-service-contracts-application-layer point 6.4.1.3lib/internal/Magento/Framework/View/Design/Theme/Domain/PhysicalInterface
found next usages:\Magento\Framework\View\Design\Theme\Domain\Factory::$_types
:app/etc/di.xml:78
:So i non't touch this class.
lib/internal/Magento/Framework/View/Design/Theme/Domain/StagingInterface
found next usages:\Magento\Framework\View\Design\Theme\Domain\Factory::$_types
:app/etc/di.xml:80
:lib/internal/Magento/Framework/View/Design/Theme/Domain/VirtualInterface.php
found next usages:\Magento\Framework\View\Design\Theme\Domain\Factory::$_types
:app/etc/di.xml:79
:lib/internal/Magento/Framework/Filter/Encrypt/AdapterInterface.php
replaced implementation in the whole project using\Zend_Filter_Encrypt_Interface
directly in the files:lib/internal/Magento/Framework/Filter/Decrypt.php
.lib/internal/Magento/Framework/Filter/Encrypt.php
.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)