Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecated classes #32086

Open
wants to merge 4 commits into
base: 2.5-develop
Choose a base branch
from

Conversation

ProkopovVitaliy
Copy link
Contributor

@ProkopovVitaliy ProkopovVitaliy commented Feb 10, 2021

Description (*)

In tis PR i did next.

  1. If interface not used i deleted him.

  2. app/code/Magento/CustomerGraphQl/Api/ValidateCustomerDataInterface moved to Magento\CustomerGraphQl\Model\Customer folder. I moved tho the Model namespace those interfaces according to the technical vision https://devdocs.magento.com/guides/v2.4/coding-standards/technical-guidelines.html#64-service-contracts-application-layer point 6.4.1.3

  3. lib/internal/Magento/Framework/View/Design/Theme/Domain/PhysicalInterface found next usages:

  • \Magento\Framework\View\Design\Theme\Domain\Factory::$_types:
    /**
     * Types
     *
     * @var array
     */
    protected $_types = [
        ThemeInterface::TYPE_PHYSICAL => \Magento\Framework\View\Design\Theme\Domain\PhysicalInterface::class,
        ThemeInterface::TYPE_VIRTUAL => \Magento\Framework\View\Design\Theme\Domain\VirtualInterface::class,
        ThemeInterface::TYPE_STAGING => \Magento\Framework\View\Design\Theme\Domain\StagingInterface::class,
    ];
  • app/etc/di.xml:78:
<preference for="Magento\Framework\View\Design\Theme\Domain\PhysicalInterface" type="Magento\Theme\Model\Theme\Domain\Physical" />

So i non't touch this class.

  1. lib/internal/Magento/Framework/View/Design/Theme/Domain/StagingInterface found next usages:
  • \Magento\Framework\View\Design\Theme\Domain\Factory::$_types:
    /**
     * Types
     *
     * @var array
     */
    protected $_types = [
        ThemeInterface::TYPE_PHYSICAL => \Magento\Framework\View\Design\Theme\Domain\PhysicalInterface::class,
        ThemeInterface::TYPE_VIRTUAL => \Magento\Framework\View\Design\Theme\Domain\VirtualInterface::class,
        ThemeInterface::TYPE_STAGING => \Magento\Framework\View\Design\Theme\Domain\StagingInterface::class,
    ];
  • app/etc/di.xml:80:
<preference for="Magento\Framework\View\Design\Theme\Domain\StagingInterface" type="Magento\Theme\Model\Theme\Domain\Staging" />
  1. lib/internal/Magento/Framework/View/Design/Theme/Domain/VirtualInterface.php found next usages:
  • \Magento\Framework\View\Design\Theme\Domain\Factory::$_types:
    /**
     * Types
     *
     * @var array
     */
    protected $_types = [
        ThemeInterface::TYPE_PHYSICAL => \Magento\Framework\View\Design\Theme\Domain\PhysicalInterface::class,
        ThemeInterface::TYPE_VIRTUAL => \Magento\Framework\View\Design\Theme\Domain\VirtualInterface::class,
        ThemeInterface::TYPE_STAGING => \Magento\Framework\View\Design\Theme\Domain\StagingInterface::class,
    ];
  • app/etc/di.xml:79:
<preference for="Magento\Framework\View\Design\Theme\Domain\VirtualInterface" type="Magento\Theme\Model\Theme\Domain\Virtual" />
  1. lib/internal/Magento/Framework/Filter/Encrypt/AdapterInterface.php replaced implementation in the whole project using \Zend_Filter_Encrypt_Interface directly in the files:
  • lib/internal/Magento/Framework/Filter/Decrypt.php.
  • lib/internal/Magento/Framework/Filter/Encrypt.php.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Mark interfaces deprecated #32063

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @ProkopovVitaliy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 10, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 10, 2021
@coderimus
Copy link
Contributor

@magento run all tests

@gabrieldagama gabrieldagama added this to the 2.5 milestone Feb 11, 2021
@ProkopovVitaliy
Copy link
Contributor Author

@magento run all tests

@ProkopovVitaliy
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review Release Line: 2.5
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

4 participants