Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abandoned laminas-console and laminas-mvc-console dependencies #32432

Conversation

hws47a
Copy link
Contributor

@hws47a hws47a commented Mar 11, 2021

Description (*)

Remove abandoned laminas-console and laminas-mvc-console dependencies.
There is no reason to move to laminas-cli as it doesn't provide the same interfaces as laminas-console.
Laminas-console is used in one place and it's easier to replace it with argv from $application->getConfig().

As there is no Setup Wizard anymore, ideally the code in setup folder should be refactored and some other dependencies removed like laminas-mvc as it was used to have both web and console setup.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/523

Fixed Issues (if relevant)

  1. Fixes Migrate from laminas/laminas-console to laminas/laminas-cli dependency #32321
  2. Fixes Eliminate laminas/laminas-mvc-console dependency #32407

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2021

Hi @hws47a. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@hws47a
Copy link
Contributor Author

hws47a commented Mar 11, 2021

@magento run all tests

@hws47a
Copy link
Contributor Author

hws47a commented Mar 11, 2021

@magento run all tests

@hws47a hws47a marked this pull request as ready for review March 11, 2021 16:59
@hws47a
Copy link
Contributor Author

hws47a commented Mar 11, 2021

@magento run all tests

$result = array_replace_recursive($result, $this->extractFromCli($application->getRequest()));
return $result;

if (!isset($result['argv'])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following check in order to prevent type error if it's not array:

Suggested change
if (!isset($result['argv'])) {
if (!isset($result['argv']) || !is_array($result['argv'])) {

Also would be great to cover this case with a unit test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hws47a
Copy link
Contributor Author

hws47a commented Mar 13, 2021

@magento run all tests

@hws47a
Copy link
Contributor Author

hws47a commented Mar 13, 2021

@magento run all tests

2 similar comments
@hws47a
Copy link
Contributor Author

hws47a commented Mar 13, 2021

@magento run all tests

@hws47a
Copy link
Contributor Author

hws47a commented Mar 14, 2021

@magento run all tests

@hws47a
Copy link
Contributor Author

hws47a commented Mar 14, 2021

@magento run all tests

@hws47a
Copy link
Contributor Author

hws47a commented Mar 14, 2021

@magento run Functional Tests EE, Unit Tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Unit Tests

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes from this PR.

@m2-assistant
Copy link

m2-assistant bot commented Mar 15, 2021

Hi @hws47a, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants