-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove abandoned laminas-console and laminas-mvc-console dependencies #32432
Remove abandoned laminas-console and laminas-mvc-console dependencies #32432
Conversation
…nsole packages from composer
…izard is removed
Hi @hws47a. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
@magento run all tests |
$result = array_replace_recursive($result, $this->extractFromCli($application->getRequest())); | ||
return $result; | ||
|
||
if (!isset($result['argv'])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following check in order to prevent type error if it's not array:
if (!isset($result['argv'])) { | |
if (!isset($result['argv']) || !is_array($result['argv'])) { |
Also would be great to cover this case with a unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@magento run all tests |
@magento run all tests |
…igrate-from-laminas-console
@magento run all tests |
@magento run Functional Tests EE, Unit Tests |
@magento run Functional Tests B2B, Functional Tests EE, Unit Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests looks not related to changes from this PR.
Hi @hws47a, thank you for your contribution! |
Description (*)
Remove abandoned laminas-console and laminas-mvc-console dependencies.
There is no reason to move to laminas-cli as it doesn't provide the same interfaces as laminas-console.
Laminas-console is used in one place and it's easier to replace it with argv from
$application->getConfig()
.As there is no Setup Wizard anymore, ideally the code in
setup
folder should be refactored and some other dependencies removed like laminas-mvc as it was used to have both web and console setup.Related Pull Requests
https://github.com/magento/partners-magento2ee/pull/523
Fixed Issues (if relevant)
Contribution checklist (*)