Laminas di and servicemanager updated to PHP 8 compatible version #31854

ProkopovVitaliy · 2021-01-27T11:21:28Z

Description (*)

Updated laminas/laminas-di to ^3.2.0
Updated laminas/laminas-servicemanager to ^3.6.0
Updated laminas/laminas-mvc to ^3.2.0

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/515

Fixed Issues

Resolves Update laminas/laminas-di dependency to PHP 8 compatible version #31173
Resolves Update laminas/laminas-servicemanager dependency version to "^3.5.1" #31346
Resolves Update laminas/laminas-mvc dependency to PHP 8 compatible version #31783

m2-assistant · 2021-01-27T11:21:30Z

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

coderimus · 2021-01-27T13:24:41Z

@magento run all tests

coderimus

@ProkopovVitaliy thank you for the provided changes. Please, take a look at the composer.lock file conflicts. Think that we will have more tests passed after resolving it because we have some updates :)

ProkopovVitaliy · 2021-01-27T14:42:14Z

@coderimus resolved conflict in composer.lock.

coderimus · 2021-01-27T14:48:10Z

@magento run all tests

ProkopovVitaliy · 2021-01-28T06:54:56Z

@magento run all tests

coderimus · 2021-02-01T09:40:21Z

@ProkopovVitaliy I found an issue with the BIC:

Class 'Laminas\Di\Di' not found
#0 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestCase.php(772): PHPUnit\Framework\TestResult->run()
#1 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php(639): PHPUnit\Framework\TestCase->run()
#2 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php(639): PHPUnit\Framework\TestSuite->run()
#3 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php(639): PHPUnit\Framework\TestSuite->run()
#4 /var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(653): PHPUnit\Framework\TestSuite->run()
#5 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php(108): PHPUnit\TextUI\TestRunner->run()
#6 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php(68): PHPUnit\TextUI\Command->run()
#7 /var/www/html/vendor/phpunit/phpunit/phpunit(61): PHPUnit\TextUI\Command::main()
#8 {main}

This relates to the https://github.com/laminas/laminas-di/blob/3.3.x/CHANGELOG.md#300---2017-11-30 where Laminas\Di\Di is removed in favour of Laminas\Di\DefaultContainer. Please, use new approach

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31854/4ab73ccf4b21a49b02b87d3bc756fb67/Unit/allure-report-ce/index.html#suites/8c9f62e899e10027257cb48ea8392992/fed49d5050bc2508/

… into 31173-laminas-di-dependency

sivaschenko · 2021-03-03T15:20:22Z

@magento run all tests

sivaschenko · 2021-03-03T15:28:04Z

@coderimus @ProkopovVitaliy @konarshankar07 @Den4ik looks like servicemanager update depend on di and vice versa, so we have to update them together. Added servicemanager update to this PR.

Den4ik · 2021-03-03T20:23:42Z

setup/src/Magento/Setup/Mvc/Bootstrap/InitParamListener.php

    public function createService(ServiceLocatorInterface $serviceLocator)
    {
-        return $this->extractInitParameters($serviceLocator->get('Application'));
+        return $this($serviceLocator, 'Application');
+    }


I believe that we may just replace this method with __invoke instead of extend the class by the new method.
@sivaschenko please, correct me if I'm not right

I'd prefer to keep the existing method for backward compatibility purposes

I agree, but it's setup sources. I'm not sure that someone extends or customizes the setup process.

Yes, you are probably right

sivaschenko · 2021-03-04T15:51:21Z

Updated laminas-mvc in this PR as well. Still trying to resolve the issue: Laminas DI attempts to instantiate even optional constructor parameters (and fails to do so)

…ctor parameters

sivaschenko · 2021-03-05T14:09:37Z

@magento run all tests

…iated by laminas di

sivaschenko · 2021-03-05T18:11:32Z

@magento run all tests

…t handle

sivaschenko · 2021-03-06T16:34:20Z

@magento run all tests

sivaschenko · 2021-03-06T17:57:53Z

Remaining issue to resolve:
Setup integration tests are failing with the error Connection "default" is not defined. This issue looks to be caused by missing env.php in dev/tests/setup-integration/tmp/etc during tests execution.

sivaschenko · 2021-03-09T16:30:20Z

@magento run all tests

m2-assistant · 2021-03-09T19:00:50Z

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…nsole packages from composer

updated laminas/laminas-di module

f2e70de

magento-engcom-team added the Release Line: 2.4 label Jan 27, 2021

m2-community-project bot added the Progress: pending review label Jan 27, 2021

ProkopovVitaliy changed the base branch from 2.4-develop to php8-develop January 27, 2021 11:33

coderimus self-assigned this Jan 27, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 27, 2021

coderimus suggested changes Jan 27, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 27, 2021

Merge branch 'php8-develop' into 31173-laminas-di-dependency

967762f

Merge branch 'php8-develop' into 31173-laminas-di-dependency

81be920

gabrieldagama added the Project: PHP8 label Jan 28, 2021

coderimus added the Award: complex label Feb 1, 2021

sivaschenko mentioned this pull request Mar 3, 2021

#31346 :- Update laminas/laminas-servicemanager #32234

Closed

4 tasks

sivaschenko self-assigned this Mar 3, 2021

sivaschenko added 2 commits March 3, 2021 14:42

Merge branch 'php8-develop' of github.com:magento-commerce/magento2ce…

87ca953

… into 31173-laminas-di-dependency

magento#31346: Updated laminas/laminas-servicemanager

2dd88ef

sivaschenko changed the title ~~31173 laminas di dependency~~ Laminas di and servicemanager updated to PHP 8 compatible version Mar 3, 2021

Den4ik reviewed Mar 3, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Mar 3, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Mar 3, 2021

magento#31783: Updated laminas-mvc

98925c2

sivaschenko changed the title ~~Laminas di and servicemanager updated to PHP 8 compatible version~~ [WIP] Laminas di and servicemanager updated to PHP 8 compatible version Mar 4, 2021

magento#31854: Customized laminas-di to resolve only required constru…

4416bc1

…ctor parameters

magento#31854: Removed optional parameters types from classes instant…

53f2905

…iated by laminas di

magento#31854: Utilized Magento DI for loading types Laminas DI canno…

8a6d064

…t handle

magento#31783: Added laminas-mvc-console dependency

c9f729b

sivaschenko changed the title ~~[WIP] Laminas di and servicemanager updated to PHP 8 compatible version~~ Laminas di and servicemanager updated to PHP 8 compatible version Mar 9, 2021

sivaschenko approved these changes Mar 9, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Mar 9, 2021

magento-cicd2 merged commit 21c3055 into magento:php8-develop Mar 9, 2021

sivaschenko mentioned this pull request Mar 9, 2021

Eliminate laminas/laminas-mvc-console dependency #32407

Closed

hws47a added a commit to hws47a/magento2 that referenced this pull request Mar 11, 2021

magento#32321 magento#31854 remove laminas-console and laminas-mvc-co…

c75bd62

…nsole packages from composer

hws47a mentioned this pull request Mar 11, 2021

Remove abandoned laminas-console and laminas-mvc-console dependencies #32432

Merged

4 tasks

hws47a added a commit to hws47a/magento2 that referenced this pull request Mar 11, 2021

magento#31854 Remove Laminas\Mvc\Console from modules.config.php

3fe67e3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Laminas di and servicemanager updated to PHP 8 compatible version #31854

Laminas di and servicemanager updated to PHP 8 compatible version #31854

ProkopovVitaliy commented Jan 27, 2021 •

edited by sivaschenko

Loading

m2-assistant bot commented Jan 27, 2021

coderimus commented Jan 27, 2021

coderimus left a comment

ProkopovVitaliy commented Jan 27, 2021

coderimus commented Jan 27, 2021

ProkopovVitaliy commented Jan 28, 2021

coderimus commented Feb 1, 2021

sivaschenko commented Mar 3, 2021

sivaschenko commented Mar 3, 2021

Den4ik Mar 3, 2021

sivaschenko Mar 3, 2021

Den4ik Mar 3, 2021

sivaschenko Mar 4, 2021

sivaschenko commented Mar 4, 2021

sivaschenko commented Mar 5, 2021

sivaschenko commented Mar 5, 2021

sivaschenko commented Mar 6, 2021

sivaschenko commented Mar 6, 2021

sivaschenko commented Mar 9, 2021

m2-assistant bot commented Mar 9, 2021

Laminas di and servicemanager updated to PHP 8 compatible version #31854

Laminas di and servicemanager updated to PHP 8 compatible version #31854

Conversation

ProkopovVitaliy commented Jan 27, 2021 • edited by sivaschenko Loading

Description (*)

Related Pull Requests

Fixed Issues

m2-assistant bot commented Jan 27, 2021

coderimus commented Jan 27, 2021

coderimus left a comment

Choose a reason for hiding this comment

ProkopovVitaliy commented Jan 27, 2021

coderimus commented Jan 27, 2021

ProkopovVitaliy commented Jan 28, 2021

coderimus commented Feb 1, 2021

sivaschenko commented Mar 3, 2021

sivaschenko commented Mar 3, 2021

Den4ik Mar 3, 2021

Choose a reason for hiding this comment

sivaschenko Mar 3, 2021

Choose a reason for hiding this comment

Den4ik Mar 3, 2021

Choose a reason for hiding this comment

sivaschenko Mar 4, 2021

Choose a reason for hiding this comment

sivaschenko commented Mar 4, 2021

sivaschenko commented Mar 5, 2021

sivaschenko commented Mar 5, 2021

sivaschenko commented Mar 6, 2021

sivaschenko commented Mar 6, 2021

sivaschenko commented Mar 9, 2021

m2-assistant bot commented Mar 9, 2021

ProkopovVitaliy commented Jan 27, 2021 •

edited by sivaschenko

Loading