33206: Removed lib/web/es6-collections.js and replaced usages with native JS

[anzin]

Description (*)

I've removed lib/web/es6-collections.js and replaced usages with native JS

Fixed Issues (if relevant)

1. Fixes Eliminate es6-collections.js #33206

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @anzin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

✅ Looks ok for me

Failed tests is not related to changes

[ihor-sviziev]

@sivaschenko @sidolov, could you provide some info on why the unit tests are failing w/o any errors in the results?

[andrewbess]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[andrewbess]

@magento run Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[sivaschenko]

@anzin @andrewbess if the WeakMap isn't supported by the library for js unit tests can you please take a look if this issue can be resolved by updating npm packages or (less preferable) adding an additional dependency to package.json

[ihor-sviziev]

FYI here is a WIP PR for updating the js unit test library #33429.

[ihor-sviziev]

I just ran the tests on the local machine with the newer js unit test library (see #33429) - we have more than 100 failing tests with a new version. It's definitely not easy to fix them altogether.
I think it's better to keep the old version for now.

[andrewbess]

@mageno run Unit Tests

[andrewbess]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@anzin @andrewbess if the WeakMap isn't supported by the library for js unit tests can you please take a look if this issue can be resolved by updating npm packages or (less preferable) adding an additional dependency to package.json

I believe that we can use es6-collections polyfilll at js tests due to unsupport es6 by phantomjs.
Something like attached patch file
es6-collections-in-js-tests.tar.gz

[andrewbess]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2b, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[andrewbess]

Hello @Den4ik @sivaschenko
All tests have been run successfully.
The ignoring of the eslint and jscs were added because the file added to tests is original es6-collections.js from the lib/web/ directory.
Please approve this changes.
Thank you in advance.

[m2-assistant]

Hi @anzin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.