Fix integration test syntax error #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nevvermind, thank you for catching and fixing this issue. We will merge it ASAP. |
|
The value assignment during property declaration using |
|
Sooo... instead of merging a simple fix, M2 should bump their PHP version? |
This was referenced Apr 29, 2016
magento-team
pushed a commit
that referenced
this pull request
Apr 30, 2016
Making compatible with PHP 5.5
magento-team
pushed a commit
that referenced
this pull request
Apr 30, 2016
Making compatible with PHP 5.5
|
@nevvermind your pull request has been accepted, thank you for contribution. We have to modify it, because we have two tests that extend this one. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
Making compatible with PHP 5.5
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
Making compatible with PHP 5.5
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
Making compatible with PHP 5.5
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
Making compatible with PHP 5.5
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
Making compatible with PHP 5.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this one got into mainline, but it makes all CI integration tests fail.
And, no, phpstorm didn't pick it up as an error.