Adds test for getDataUsingMethod using digits #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't see how the travis failure
would be related to the addition of a unit test. |
|
@mazhalai do you know what needs to be done? resubmitted based on latest version? |
|
@fooman can you sync with develop branch please? It this has been fixed in develop branch already. |
fooman
force-pushed
the
extra-test-documenting-getDataUsingMethod
branch
from
2eaeb4b to
d2d1d19
Compare
|
@mazhalai done |
|
Internal ticket created - MAGETWO-56728 |
mmansoor-magento
pushed a commit
that referenced
this pull request
Aug 21, 2016
…gits #4354 - Merge branch 'extra-test-documenting-getDataUsingMethod' of https://github.com/fooman/magento2 into fooman-extra-test-documenting-getDataUsingMethod
vkorotun
added
Issue: Ready for Work
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 14, 2019
[Performance] Introduce CSS critical path and font display swap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test to document the current behaviour of
Magento\Framework\DataObject::_underscore- in particulargetDataUsingMethod('key2')exposes the inbuilt assumption from _underscore that any digit is preceded by an underscore.