Patch for code that is not following best practices in Magento development #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o use more appropriate load() method of the model.
|
@IvanChepurnyi Automated tests for these particular changes appeared to be pretty simple, so we implemented them. Closing the ticket |
magento-team
added a commit
that referenced
this pull request
Aug 27, 2012
* Decoupled Tag module functionality from other modules * Visual Design Editor: * Implemented tracking of user changes history and rendering the actions at VDE toolbar * Implemented compacting of user changes history. Compacting is done in order to save all the changes as a minimal layout update. * Improvements: * Added Atlassian IDE Plugin configuration files to `.gitignore` * Relocated `add_to_cart`, `checkout` and `product_edit` performance scenarios from `samples` to the normal `testsuite` directory. These scenarios can be used for Magento performance testing. * Implemented verification of number of orders that were created during execution of `checkout` performance scenario * Removed usage of deprecated `PHPUnit_Extensions_OutputTestCase` class from unit tests * Fixes: * Fixed MySQL DB adapter to always throw exception, if it was not able to connect to DB because of wrong configuration. So now the adapter's behavior is not dependent on `error_reporting` settings. * Added the missing closing tag to New Order email template * Fixed `Mage_ImportExport_Model_Import_Entity_CustomerComposite` integration test issues * Marked several integration tests in `Mage_Adminhtml_CustomerControllerTest` as incomplete, as the tested functionality was not MMDB-compliant * Fixed issue with unit tests failure, when there was a Zend Framework installed as PEAR package * Fixed `advanced_search` performance scenario to fail, if the searched product doesn't exist * Fixed issue with non-escaped latest message link in admin backend * GitHub requests: * [#48](#48) -- fixed usage of a collection at the place, where just a single object was needed
magento-team
pushed a commit
that referenced
this pull request
Jan 23, 2015
[Firedrakes] Magento vendor name is used as a framework namespace
Closed
Closed
This was referenced Nov 22, 2015
magento-engcom-team
pushed a commit
that referenced
this pull request
May 31, 2018
Include 'products' in category query
magento-engcom-team
pushed a commit
that referenced
this pull request
May 31, 2018
- Fixed test in case when indexer mode is 'on schedule'
magento-engcom-team
pushed a commit
that referenced
this pull request
May 31, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 31, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 31, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 27, 2018
MAGETWO-66666: Adding a product to cart from category page with an ex…
5 tasks
ghost
mentioned this pull request
1 task
5 tasks
5 tasks
ghost
mentioned this pull request
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See attached commit, where using of collection for retrieving address by id is replaced by using of standard load method of the model.
Created as new pull request, since previous one was using master branch, instead of custom one.