Converted several grids from Magento\Sales module to new layout xml config format: #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved common order grid parts to appropriate classes - refactored mass actions block, made action names consistent - added new acl Magento_Sales::print for pdf generation related mass actions
- converted Magento\Sales\Block\Adminhtml\Invoice\Grid to new layout xml config format
- refactored class Magento\Backend\App\Action\Order - made all actions consistent, removed obsolete actions
- converted Magento\Sales\Block\Adminhtml\Order\View\Tab\Invoices to new layout xml config format
- fixed method phpdocs
- converted Magento\Sales\Block\Adminhtml\Shipment\Grid to new layout xml config format
- converted Magento\Sales\Block\Adminhtml\Order\View\Tab\Shipments to new layout xml config format
- converted Magento\Sales\Block\Adminhtml\Creditmemo\Grid to new layout xml config format
- converted Magento\Sales\Block\Adminhtml\Order\View\Tab\Creditmemos to new layout xml config format
- fixed method phpdocs
- converted Magento\Sales\Block\Adminhtml\Transactions\Grid and Magento\Sales\Block\Adminhtml\Order\View\Tab\Transactions to new layout xml config format
|
@Zyava , thank you for your contribution! We will consider including your contribution to the Magento 2 code base. |
magento-team
added a commit
that referenced
this pull request
Apr 18, 2014
* Pricing Improvements:
* Added price calculation component to library
* Eliminated price calculation from blocks and templates and implemented new calculation models for the following product types:
* Bundle
* Simple/Virtual
* Grouped
* Downloadable
* Resolved price calculation dependencies on the Tax and Weee modules
* Themes update:
* Updated the look&feel of the Admin theme
* Fixed bugs:
* Fixed an issue with the inability to save product with grouped price when Price Scope = Website
* Fixed an issue with fatal error on attempt to edit product from wishlist in stores with multiple store views
* Fixed an issue where it was impossible to add to a wishlist a product with custom quantity
* Fixed an issue where JS validation was skipped during CMS page creation
* Fixed an issue with the New Customer Address Attribute page and the New Customer Attribute page having the same title
* Fixed an issue where a form was submitted two times during CMS page creation
* Fixed an issue where a fatal error appeared when trying to edit product in a wishlist in stores with multiple store views
* Fixed an issue with inability to change page layout for categories
* Fixed an issue where the Quantity drop-down list box was disabled for bundle products
* Fixed an issue where inactive Related Products rules were applied
* Fixed a clickjacking vulnerability
* Fixed bugs and added improvements in the Blank theme
* Fixed an issue where the Flat Rate shipping method was not enabled by default
* Fixed an issue with incorrect order of products on the Add Product split button
* Fixed an issue with saving the tier price attribute value
* Fixed an issue with creating integration from config file
* Fixed an issue where the Cookie Restriction Mode = Yes configuration was not applied
* Fixed an issue where it was impossible to perform ajax actions from backend grids in Internet Explorer
* Fixed the improper usage of DIRECTORY_SEPARATOR
* Fixed an issue where it was impossible to add new address on customer's account page if default address had been already set
* Fixed an issue where setting memory_limit to -1 caused installation failure
* Fixed an issue where the configuration of Admin Session Lifetime was not applied correctly
* Fixed an issue where Scheduled Export was not performed if exporting to remote FTP server
* Fixed the wrong default value for PHP memory_limit
* Fixed an issue where frontend messages were not displayed when FPC was turned off
* Fixed the position of page action buttons on the Categories page in the backend
* Improved backend grids UI
* Framework Improvements:
* Simplified Search related Data Objects
* Moved lib/Magento/* to lib/Magento/Framework/*
* Moved lib/Magento/App to lib/Magento/Framework/App
* Refactored the following modules to use Customer service:
* PayPalRecurringPayment
* RecurringPayment
* Multishipping
* Paypal
* Customer Service usage:
* Implemented Service Context Provider
* Restructured webapi.xml
* Renamed createAccount to createCustomer in CustomerAccountService
* Implemented Caching strategy for the Customer service
* GitHub requests:
* [#488] (#488) -- Converted several grids from Magento\Sales module to new layout XML config format
|
@Zyava, the team has processed your pull request. The code is available in version dev74 we have just released to GitHub. Thank you again for your contribution! Looking forward for new issues and pull requests from you! |
|
👍 |
okorshenko
pushed a commit
that referenced
this pull request
Dec 14, 2016
Fixed issue: - MAGETWO-58902 [Backport] Custom address attribute not appearing on Checkout summary
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 5, 2019
…Ql\Model\Cart\SetBillingAddressOnCart` #488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of converted grids: