Fix issue #4470: import.xsd doesn't allow numbers in vendor name and class name #5420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to have model definitions that were not parsable in the xml because it validated the xsd specificatons. There was no Problem in adding those Models and use them but not with that .xsd file.
I do not know if those make sense now, but at least the look like it could be ok.
|
Probably needs some fixing in test files aswell..? |
|
will do that asap. They did not pop up for me because of beeing from 5.6 tests it looks like. |
|
|
|
I suggest to do the fix similarly to ced639a We have digits in the vendor name |
tkn98
added a commit
to tkn98/magento2
that referenced
this pull request
Mar 29, 2017
The solidusbackslash character ("\") was put more than once in the same
regex character class across some XSD files. Per each character class
there is no need to specify it twice.
I ran over this while looking into an issue with class-name validation
which do not allow digits within class names.
Refs:
- https://www.w3.org/TR/xmlschema11-2/#cces
- magento#4470
- magento#5420
- magento#8307
|
@nhp thank you for your contribution. Could you please resolve the conflicts so that I can proceed with PR acceptance if this PR is still relevant. |
okorshenko
changed the title
|
Closing this PR due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to have model definitions that were not parsable
in the xml because it validated the xsd specificatons.
There was no Problem in adding those Models and use them but
not with that .xsd file.