Allow digits in communication class type definition #8307
Conversation
Our company vendor prefix "N98" is not allowed. The XSD prohibits the usage of digits.
|
@cmuench can you please create integration test to expose the issue? You can update existing fixture: dev/tests/integration/testsuite/Magento/Framework/Communication/_files/valid_communication.xml |
|
@cmuench also I noticed, that the schema attribute of the topic node has the similar issue. Do you use any custom schema? Probably should be fixed as well |
|
Thank you for contribution to Magento 2 project! |
|
Thanks for the fix, albeit for the flaw, this has more incarnations and like this issue it looks like that these are reported each on it's own (e.g. #4470 / #5420). The more fixes will be done peu-a-peu, the harder it will become to fix the flaw in it's whole. What about creating one issue we can review the XML type and check the diverse formats for same patterns? |
The solidusbackslash character ("\") was put more than once in the same
regex character class across some XSD files. Per each character class
there is no need to specify it twice.
I ran over this while looking into an issue with class-name validation
which do not allow digits within class names.
Refs:
- https://www.w3.org/TR/xmlschema11-2/#cces
- magento#4470
- magento#5420
- magento#8307
Our company vendor prefix "N98" is not allowed. The XSD prohibits the usage of digits.