Fix issue with Mage/GoogleCheckout reference in Mage/Sales module #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IvanChepurnyi, thank you for the fix. You're right, that |
|
Please remove Mage/GoogleCheckout module at all and then you will get a fatal error. |
|
@IvanChepurnyi , thank you for the test case. You are right, it's reproduced if only |
magento-team
added a commit
that referenced
this pull request
Sep 14, 2012
* Implemented the option to enable the single store mode in the system configuration, which simplifies the back-end GUI: * Hiding scope labels from the system configuration * Hiding the scope switcher from the CMS management pages and the system configuration * Hiding scope related fields from the system configuration * Hiding scope related columns and fields from the sales pages (order, invoice, shipment pages) * Hiding scope related fields from the promotions * Hiding scope related fields from the catalog pages * Hiding scope related columns and fields from the customers management page * Hiding scope related columns and fields from the customer and customer address attributes management pages * Implemented the history management for the Visual Design Editor * Implemented the user interface for themes management, which allows to list existing themes and add new ones * Replaced all usages of the old JavaScript translations mechanism with the new jQuery one * Refactored methods with high cyclomatic complexity * Converted some surrogate integration tests into functional Selenium tests * Converted some surrogate integration tests into unit tests * Fixes: * Fixed inability to install application with a prefix defined for database tables * Fixed displaying fields with model name in the payment methods settings * Fixed performance degradation of the back-end menu rendering * Fixed absence of the success message upon newsletter template creation/deletion/queueing * Workaround for occasional segmentation fault in integration tests caused by `Mage_Core_Model_Resource_Setup_Migration` * GitHub requests: * [#51](#51) -- fixed managing of scope-spefic values for Categories * [#56](#56) -- removed excessive semicolon in the CSS file * [#60](#60) -- fixed taking bind parameters into account in `Mage_Core_Model_Resource_Db_Collection_Abstract::getAllIds()` * [#61](#61) -- relocated declaration of the "Google Checkout" payment method into `Mage_GoogleCheckout` module from `Mage_Sales`
vpelipenko
added a commit
that referenced
this pull request
Jan 30, 2015
[Github] extra tests for current interception behavior #965
Closed
Closed
okorshenko
pushed a commit
that referenced
this pull request
Oct 29, 2015
[Merchant beta][Nord] Import/Export bugs fixes
This was referenced Nov 22, 2015
ghost
mentioned this pull request
ghost
mentioned this pull request
ghost
mentioned this pull request
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 27, 2018
MAGETWO-91701: Newsletter subscription is not correctly updated when …
5 tasks
ghost
mentioned this pull request
1 task
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you disable Mage/GoogleCheckout module, during checkout process there will be a fatal error since payment model of google checkout module that is marked as active gets retrieved. It is wrong behavior, since sales module shouldn't depend on a particular payment method.
The following pull request contain proper fix of that issue.