Validation change for Text type EAV attributes

[tim-reynolds]

The call on Mage_Eav_Model_Attribute_Data_Text:67 to empty returns true of a value of "0" is entered, as specified in the PHP spec. This prevents the entry of zero on the backend admin for fields. Zero should be a valid value, as it was in our case.

No unit tests were created, as no unit tests exist currently for the Eav module.

I originally changed the code to the more complex:
if ($attribute->getIsRequired() &&
(
(is_array($value) && empty($value)) ||
(is_string($value) && strlen(trim($value))==0)
)

However, I wasn't sure that would catch all cases. I was also unsure if an array or numeric value would ever pass into the validator. I felt the cast-less comparison against the primary issue input was the best solution.

[tim-reynolds]

Ignore my comment about Unit tests. I hadn't synced my fork in a while. I am so absent minded. Working on a unit test right now.

[Forestsoft-de]

why do you close your pull request tim?

[tim-reynolds]

I opened a new one. Github didn't give me the option to amend my pull request.

Sent from my iPhone

On Aug 17, 2012, at 6:47 PM, "Sebastian" <notifications@github.commailto:notifications@github.com> wrote:

why do you close your pull request tim?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/62#issuecomment-7837264.