Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework][Translate] Changed translation order to allow language #7142

Merged
merged 1 commit into from
Mar 21, 2017
Merged

[Framework][Translate] Changed translation order to allow language #7142

merged 1 commit into from
Mar 21, 2017

Conversation

JSchlarb
Copy link
Contributor

@JSchlarb JSchlarb commented Oct 22, 2016

Pull request is already done by #4783 but he didn't update the test.

Issues: #6563, #6753

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 22, 2016

CLA assistant check
All committers have signed the CLA.

@PascalBrouwers
Copy link
Contributor

@piotrekkaminski Care to take a look at this one and get it merged? This one is a bit better than #4783 I think.

@schmengler schmengler self-assigned this Mar 10, 2017
@schmengler schmengler added this to the March 2017 milestone Mar 10, 2017
@schmengler
Copy link
Contributor

Thank you for your contribution, this is a very valuable PR! I confirmed with the Magento team that we can accept the change 👍

@magento-team magento-team merged commit 38d4e24 into magento:develop Mar 21, 2017
@vrann
Copy link
Contributor

vrann commented Mar 21, 2017

@JSchlarb PR is merged, thanks for the contribution!

@shyamranpara
Copy link
Contributor

@magento-team
if this is fixed then why document is not updated ?
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/translations/theme_dictionary.html
this still show wrong order of translation priority.

@alexadvance
Copy link

Doc is wrong. It's confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants