Wrong mimetype returned by getMimeType from Magento library #716 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 8, 2014 12:19
Just load the needed weee attributs and avoid a sort. The difference is really big when you have a lot of attributs
Conflicts: app/code/Magento/Weee/Model/Tax.php
okorshenko
pushed a commit
that referenced
this pull request
Feb 7, 2017
[TSG] Backporting for 2.1 (prs2)
VitaliyBoyko
pushed a commit
to VitaliyBoyko/magento2
that referenced
this pull request
Jun 22, 2018
VitaliyBoyko
pushed a commit
to VitaliyBoyko/magento2
that referenced
this pull request
Jun 22, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 5, 2019
- Reverted BIC actiongroup change - Changed actionGroup to extend existing - Moved test materials from incorrect modules back into correct module - added cleanup steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue which is present in getMimeType function.
In some cases it would return an integer (constant) instead of a string, for example 2 instead of "image/jpeg"