Fix email template creation date not being persisted #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database schema from https://github.com/magento/magento2/blob/develop/app/code/Magento/Email/sql/email_setup/install-2.0.0.php#L62-L67 uses the column `added_at` for storing the date the email template creation date. When `setCreatedAt` is used, that date is not persisted to the database, leaving the column `NULL` in the database.
|
Code Review passed |
maksek
pushed a commit
that referenced
this pull request
Dec 25, 2014
Fix email template creation date not being persisted (MAGETWO-32152)
mmansoor-magento
pushed a commit
that referenced
this pull request
Feb 21, 2017
[Mavericks] Extend functional tests coverage - Tasks: - MTA-3977: Create auto test for Checkout using PayPal Braintree button if Require Customer's Billing Address = Yes - MTA-4065: Import Advanced Pricing if Incorrect Data
magento-engcom-team
added a commit
that referenced
this pull request
Aug 29, 2019
…bleProductGra… #859 - Merge Pull Request magento/graphql-ce#859 from danslo/graphql-ce:configurable-product-graph-ql-dependency - Merged commits: 1. ccf86d3
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database schema from https://github.com/magento/magento2/blob/develop/app/code/Magento/Email/sql/email_setup/install-2.0.0.php#L62-L67 uses the column
added_atfor storing the date the email template creation date. WhensetCreatedAtis used, that date is not persisted to the database, leaving the columnNULLin the database.